test: remove third argument from assert.strictEqual() · nodejs/node@33994d8 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 758
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 33994d8

Browse filesBrowse the repository at this point in the historyBrowse files

diprudnikov

authored and

targos

committed

test: remove third argument from assert.strictEqual()

`test/parallel/test-util-inspect.js` has a call to `assert.strictEqual()` that receives three arguments. The third argument is a string literal. Unfortunately, calling assert.strictEqual() this way means that if there is an AssertionError, the value of the variables pos and npos are not reported. This PR removes this argument. PR-URL: #22371 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>

1 parent 660c515 commit 33994d8
Copy full SHA for 33994d8

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-util-inspect.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-util-inspect.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-util-inspect.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1031,7 +1031,7 @@ if (typeof Symbol !== 'undefined') {
1031	1031	const npos = line.search(numRE);
1032	1032	if (npos !== -1) {
1033	1033	if (pos !== undefined) {
1034		- assert.strictEqual(pos, npos, 'container items not aligned');
	1034	+ assert.strictEqual(pos, npos);
1035	1035	}
1036	1036	pos = npos;
1037	1037	}

0 commit comments

Comments

0 (0)