Commit 3401315
test: use newish OpenSSL feature in test-tls-dhe
According to the comment that is being replaced here, this was not
possible with the current version of OpenSSL 1.0.2 at the time the test
was written. New OpenSSL versions appear to always print the length of
the temporary key.
Refs: nodejs/node-v0.x-archive#8272
PR-URL: #46708
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 320ddc0 commit 3401315
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -77,8 +77,8 @@ function test(keylen, expectedCipher, cb) { | |||
| 77 | 77 | out += d; | |
| 78 | 78 | }); | |
| 79 | 79 | client.stdout.on('end', function() { | |
| 80 | - // DHE key length can be checked -brief option in s_client but it | ||
| 81 | - // is only supported in openssl 1.0.2 so we cannot check it. | ||
| 80 | + assert(keylen === 'error' || | ||
| 81 | + out.includes(`Server Temp Key: DH, ${keylen} bits`)); | ||
| 82 | 82 | const reg = new RegExp(`Cipher : ${expectedCipher}`); | |
| 83 | 83 | if (reg.test(out)) { | |
| 84 | 84 | nsuccess++; | |
0 commit comments