Commit 3444458
test: add test cases for path
Add test cases for the following line.
https://github.com/nodejs/node/blob/0f2f8ef/lib/path.js#L1364
https://github.com/nodejs/node/blob/0f2f8ef/lib/path.js#L1347
PR-URL: #11453
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 4bcf1a0 commit 3444458
1 file changed
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -10,6 +10,7 @@ const failures = []; | |||
| 10 | 10 | // path.basename tests | |
| 11 | 11 | assert.strictEqual(path.basename(f), 'test-path.js'); | |
| 12 | 12 | assert.strictEqual(path.basename(f, '.js'), 'test-path'); | |
| 13 | + assert.strictEqual(path.basename('.js', '.js'), ''); | ||
| 13 | 14 | assert.strictEqual(path.basename(''), ''); | |
| 14 | 15 | assert.strictEqual(path.basename('/dir/basename.ext'), 'basename.ext'); | |
| 15 | 16 | assert.strictEqual(path.basename('/basename.ext'), 'basename.ext'); | |
@@ -74,6 +75,7 @@ assert.strictEqual(path.posix.dirname('/a'), '/'); | |||
| 74 | 75 | assert.strictEqual(path.posix.dirname(''), '.'); | |
| 75 | 76 | assert.strictEqual(path.posix.dirname('/'), '/'); | |
| 76 | 77 | assert.strictEqual(path.posix.dirname('////'), '/'); | |
| 78 | + assert.strictEqual(path.posix.dirname('//a'), '//'); | ||
| 77 | 79 | assert.strictEqual(path.posix.dirname('foo'), '.'); | |
| 78 | 80 | ||
| 79 | 81 | assert.strictEqual(path.win32.dirname('c:\\'), 'c:\\'); | |
0 commit comments