Commit 34c0701
deps: V8: cherry-pick 00bb1a77c03e
Original commit message:
[date] Fix Date#getMinutes() test failures
After building V8 using Clang (./out/x64.release/v8_build_config.json
says that "is_clang" is true), I could reproduce the referenced bug
report locally. Replacing the getMinutes() calls with getUTCMinutes()
calls fixed the test failure.
Signed-off-by: Darshan Sen <raisinten@gmail.com>
Bug: v8:11200
Change-Id: Ia36be481f2c8728380d550ead856ef8e51b1069c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093362
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76367}
Refs: v8/v8@00bb1a7
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
PR-URL: #39829
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 615477f commit 34c0701
3 files changed
Lines changed: 7 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.83', | ||
| 39 | + 'v8_embedder_string': '-node.84', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -79,6 +79,7 @@ Colin Ihrig <cjihrig@gmail.com> | |||
| 79 | 79 | Daniel Andersson <kodandersson@gmail.com> | |
| 80 | 80 | Daniel Bevenius <daniel.bevenius@gmail.com> | |
| 81 | 81 | Daniel James <dnljms@gmail.com> | |
| 82 | + Darshan Sen <raisinten@gmail.com> | ||
| 82 | 83 | David Carlier <devnexen@gmail.com> | |
| 83 | 84 | David Manouchehri <david@davidmanouchehri.com> | |
| 84 | 85 | Deepak Mohan <hop2deep@gmail.com> | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3,21 +3,21 @@ | |||
| 3 | 3 | // found in the LICENSE file. | |
| 4 | 4 | ||
| 5 | 5 | var date = new Date("2016/01/02 10:00 GMT-8") | |
| 6 | - assertEquals(0, date.getMinutes()); | ||
| 6 | + assertEquals(0, date.getUTCMinutes()); | ||
| 7 | 7 | assertEquals(18, date.getUTCHours()); | |
| 8 | 8 | ||
| 9 | 9 | date = new Date("2016/01/02 10:00 GMT-12") | |
| 10 | - assertEquals(0, date.getMinutes()); | ||
| 10 | + assertEquals(0, date.getUTCMinutes()); | ||
| 11 | 11 | assertEquals(22, date.getUTCHours()); | |
| 12 | 12 | ||
| 13 | 13 | date = new Date("2016/01/02 10:00 GMT-123") | |
| 14 | - assertEquals(23, date.getMinutes()); | ||
| 14 | + assertEquals(23, date.getUTCMinutes()); | ||
| 15 | 15 | assertEquals(11, date.getUTCHours()); | |
| 16 | 16 | ||
| 17 | 17 | date = new Date("2016/01/02 10:00 GMT-0856") | |
| 18 | - assertEquals(56, date.getMinutes()); | ||
| 18 | + assertEquals(56, date.getUTCMinutes()); | ||
| 19 | 19 | assertEquals(18, date.getUTCHours()); | |
| 20 | 20 | ||
| 21 | 21 | date = new Date("2016/01/02 10:00 GMT-08000") | |
| 22 | - assertEquals(NaN, date.getMinutes()); | ||
| 22 | + assertEquals(NaN, date.getUTCMinutes()); | ||
| 23 | 23 | assertEquals(NaN, date.getUTCHours()); | |
0 commit comments