Commit 3513243
src: fix -Wsign-compare warnings
This commit addresses the following compilation warnings:
../src/node_crypto.cc:5053:3: warning: comparison of integers
of different signs: 'unsigned int' and 'int' [-Wsign-compare]
CHECK_EQ(n, BN_bn2binpad(r, data, n));
../src/node_crypto.cc:5054:3: warning: comparison of integers
of different signs: 'unsigned int' and 'int' [-Wsign-compare]
CHECK_EQ(n, BN_bn2binpad(s, data + n, n));
PR-URL: #30565
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>1 parent 4f85f52 commit 3513243
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5050,8 +5050,8 @@ static AllocatedBuffer ConvertSignatureToP1363(Environment* env, | |||
| 5050 | 5050 | ||
| 5051 | 5051 | const BIGNUM* r = ECDSA_SIG_get0_r(asn1_sig); | |
| 5052 | 5052 | const BIGNUM* s = ECDSA_SIG_get0_s(asn1_sig); | |
| 5053 | - CHECK_EQ(n, BN_bn2binpad(r, data, n)); | ||
| 5054 | - CHECK_EQ(n, BN_bn2binpad(s, data + n, n)); | ||
| 5053 | + CHECK_EQ(n, static_cast<unsigned int>(BN_bn2binpad(r, data, n))); | ||
| 5054 | + CHECK_EQ(n, static_cast<unsigned int>(BN_bn2binpad(s, data + n, n))); | ||
| 5055 | 5055 | ||
| 5056 | 5056 | ECDSA_SIG_free(asn1_sig); | |
| 5057 | 5057 | ||
0 commit comments