Commit 351ebf2
test: improve stability of oom test
The OOM test uses a value that caused an OOM crash from V8 on certain
machines when V8 did not notify the host of OOM soon enough.
PR-URL: #41681
Refs: https://github.com/tc39/proposal-iterator-helpers#asindexedpairs
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>1 parent 311050e commit 351ebf2
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -19,8 +19,8 @@ const tmpdir = require('../common/tmpdir'); | |||
| 19 | 19 | tmpdir.refresh(); | |
| 20 | 20 | ||
| 21 | 21 | // --max-old-space-size=3 is the min 'old space' in V8, explodes fast | |
| 22 | - const cmd = `"${process.execPath}" --max-old-space-size=3 "${__filename}"`; | ||
| 23 | - exec(`${cmd} heapBomb`, { cwd: tmpdir.path }, common.mustCall((err) => { | ||
| 22 | + const cmd = `"${process.execPath}" --max-old-space-size=30 "${__filename}"`; | ||
| 23 | + exec(`${cmd} heapBomb`, { cwd: tmpdir.path }, common.mustCall((err, stdout, stderr) => { | ||
| 24 | 24 | const msg = `Wrong exit code of ${err.code}! Expected 134 for abort`; | |
| 25 | 25 | // Note: common.nodeProcessAborted() is not asserted here because it | |
| 26 | 26 | // returns true on 134 as well as 0x80000003 (V8's base::OS::Abort) | |
0 commit comments