doc: outline when origin is set to unhandledRejection · nodejs/node@352adcb · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 592
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 352adcb

Browse filesBrowse the repository at this point in the historyBrowse files

BridgeAR

authored and

codebytere

committed

doc: outline when origin is set to unhandledRejection

The `uncaughtException` listener's origin argument was ambiguous about unhandled rejections. This should clarify when origin is set to `'unhandledRejection'`. Fixes: #32907 Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33530 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 94177da commit 352adcb
Copy full SHA for 352adcb

1 file changed

+4-2Lines changed: 4 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/api
  • process.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api/process.md‎

Copy file name to clipboardExpand all lines: doc/api/process.md

+4-2Lines changed: 4 additions & 2 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -233,8 +233,9 @@ changes:
233	233
234	234	* `err` {Error} The uncaught exception.
235	235	* `origin` {string} Indicates if the exception originates from an unhandled
236		- rejection or from synchronous errors. Can either be `'uncaughtException'` or
237		- `'unhandledRejection'`.
	236	+ rejection or from an synchronous error. Can either be `'uncaughtException'` or
	237	+ `'unhandledRejection'`. The latter is only used in conjunction with the
	238	+ [`--unhandled-rejections`][] flag set to `strict` and an unhandled rejection.
238	239
239	240	The `'uncaughtException'` event is emitted when an uncaught JavaScript
240	241	exception bubbles all the way back to the event loop. By default, Node.js
@@ -2582,6 +2583,7 @@ cases:
2582	2583	[`'exit'`]: #process_event_exit
2583	2584	[`'message'`]: child_process.html#child_process_event_message
2584	2585	[`'uncaughtException'`]: #process_event_uncaughtexception
	2586	+ [`--unhandled-rejections`]: cli.html#cli_unhandled_rejections_mode
2585	2587	[`Buffer`]: buffer.html
2586	2588	[`ChildProcess.disconnect()`]: child_process.html#child_process_subprocess_disconnect
2587	2589	[`ChildProcess.send()`]: child_process.html#child_process_subprocess_send_message_sendhandle_options_callback

0 commit comments

Comments

0 (0)