Commit 3550419
events: remove unnecessary checks
This commit removes two truthy checks for object properties that
are immediately followed by a strict equality check. The other
item in the comparison is guaranteed to be a function by this
point in the code, so the truthy check is redundant.
PR-URL: #9330
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent 31690a6 commit 3550419
1 file changed
Lines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -327,7 +327,7 @@ EventEmitter.prototype.removeListener = | |||
| 327 | 327 | if (!list) | |
| 328 | 328 | return this; | |
| 329 | 329 | ||
| 330 | - if (list === listener || (list.listener && list.listener === listener)) { | ||
| 330 | + if (list === listener || list.listener === listener) { | ||
| 331 | 331 | if (--this._eventsCount === 0) | |
| 332 | 332 | this._events = new EventHandlers(); | |
| 333 | 333 | else { | |
@@ -339,8 +339,7 @@ EventEmitter.prototype.removeListener = | |||
| 339 | 339 | position = -1; | |
| 340 | 340 | ||
| 341 | 341 | for (i = list.length; i-- > 0;) { | |
| 342 | - if (list[i] === listener || | ||
| 343 | - (list[i].listener && list[i].listener === listener)) { | ||
| 342 | + if (list[i] === listener || list[i].listener === listener) { | ||
| 344 | 343 | originalListener = list[i].listener; | |
| 345 | 344 | position = i; | |
| 346 | 345 | break; | |
0 commit comments