test: check for session.post() errors in test-insepctor-context · nodejs/node@3571e13 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 3571e13

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

addaleax

committed

test: check for session.post() errors in test-insepctor-context

If session.post() generates an error, it is currently ignored. Add check for error by adding a callback to session.post() invocation. PR-URL: #30649 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 3769632 commit 3571e13
Copy full SHA for 3571e13

1 file changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/sequential
  • test-inspector-contexts.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/sequential/test-inspector-contexts.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-inspector-contexts.js

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -5,7 +5,7 @@
5	5	const common = require('../common');
6	6	common.skipIfInspectorDisabled();
7	7
8		- const { strictEqual } = require('assert');
	8	+ const { ifError, strictEqual } = require('assert');
9	9	const { createContext, runInNewContext } = require('vm');
10	10	const { Session } = require('inspector');
11	11
@@ -22,7 +22,7 @@ async function testContextCreatedAndDestroyed() {
22	22	const mainContextPromise =
23	23	notificationPromise('Runtime.executionContextCreated');
24	24
25		- session.post('Runtime.enable');
	25	+ session.post('Runtime.enable', assert.ifError);
26	26	const contextCreated = await mainContextPromise;
27	27	const { name, origin, auxData } = contextCreated.params.context;
28	28	if (common.isSunOS || common.isWindows) {
@@ -148,7 +148,7 @@ async function testContextCreatedAndDestroyed() {
148	148
149	149	async function testBreakpointHit() {
150	150	console.log('Testing breakpoint is hit in a new context');
151		- session.post('Debugger.enable');
	151	+ session.post('Debugger.enable', assert.ifError);
152	152
153	153	const pausedPromise = notificationPromise('Debugger.paused');
154	154	runInNewContext('debugger', {});

0 commit comments

Comments

0 (0)