src: remove OnScopeLeaveImpl's move assignment overload · nodejs/node@358273d · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 358273d

Browse filesBrowse the repository at this point in the historyBrowse files

CGQAQ

authored and

targos

committed

src: remove OnScopeLeaveImpl's move assignment overload

... as it's not valid implementation and also has not been used PR-URL: #48732 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent e455dd4 commit 358273d
Copy full SHA for 358273d

1 file changed

-6Lines changed: 0 additions & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • util.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/util.h‎

Copy file name to clipboardExpand all lines: src/util.h

-6Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
@@ -568,12 +568,6 @@ struct OnScopeLeaveImpl {
568	568	: fn_(std::move(other.fn_)), active_(other.active_) {
569	569	other.active_ = false;
570	570	}
571		- OnScopeLeaveImpl& operator=(OnScopeLeaveImpl&& other) {
572		- if (this == &other) return *this;
573		- this->~OnScopeLeave();
574		- new (this)OnScopeLeaveImpl(std::move(other));
575		- return *this;
576		- }
577	571	};
578	572
579	573	// Run a function when exiting the current scope. Used like this:

0 commit comments

Comments

0 (0)