Commit 359fff1
src,build: add no user defined deduction guides of CTAD check
PR-URL: #56071
Refs: https://google.github.io/styleguide/cppguide.html#CTAD
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 17b6931 commit 359fff1
3 files changed
Lines changed: 7 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -481,6 +481,7 @@ | |||
| 481 | 481 | '-Wno-unused-parameter', | |
| 482 | 482 | '-Werror=undefined-inline', | |
| 483 | 483 | '-Werror=extra-semi', | |
| 484 | + '-Werror=ctad-maybe-unsupported', | ||
| 484 | 485 | ], | |
| 485 | 486 | }, | |
| 486 | 487 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -27,7 +27,11 @@ | |||
| 27 | 27 | ||
| 28 | 28 | 'conditions': [ | |
| 29 | 29 | [ 'clang==1', { | |
| 30 | - 'cflags': [ '-Werror=undefined-inline', '-Werror=extra-semi'] | ||
| 30 | + 'cflags': [ | ||
| 31 | + '-Werror=undefined-inline', | ||
| 32 | + '-Werror=extra-semi', | ||
| 33 | + '-Werror=ctad-maybe-unsupported', | ||
| 34 | + ], | ||
| 31 | 35 | }], | |
| 32 | 36 | [ '"<(_type)"=="executable"', { | |
| 33 | 37 | 'msvs_settings': { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1531,7 +1531,7 @@ void Session::EmitDatagram(Store&& datagram, DatagramReceivedFlags flag) { | |||
| 1531 | 1531 | DCHECK(!is_destroyed()); | |
| 1532 | 1532 | if (!env()->can_call_into_js()) return; | |
| 1533 | 1533 | ||
| 1534 | - CallbackScope cbv_scope(this); | ||
| 1534 | + CallbackScope<Session> cbv_scope(this); | ||
| 1535 | 1535 | ||
| 1536 | 1536 | Local<Value> argv[] = {datagram.ToUint8Array(env()), | |
| 1537 | 1537 | v8::Boolean::New(env()->isolate(), flag.early)}; | |
0 commit comments