Commit 35b18b4
committed
tools: fix max body length handler in create-release-proposal.sh
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #65455
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>1 parent 60cb384 commit 35b18b4
1 file changed
Lines changed: 8 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -35,9 +35,14 @@ HEAD_SHA="$(git rev-parse HEAD^)" | |||
| 35 | 35 | ||
| 36 | 36 | TITLE="$(git log -1 --format=%s)" | |
| 37 | 37 | ||
| 38 | - TEMP_BODY="$(awk -v MAX_BODY_LENGTH="65536" \ | ||
| 39 | - "/^## ${RELEASE_DATE}/,/^<a id=/{ if (/^<a id=/) {exit;} if ((output_length += length(\$0)) > MAX_BODY_LENGTH) {exit 1;} print }" \ | ||
| 40 | - "doc/changelogs/CHANGELOG_V${RELEASE_LINE}.md" || echo "…")" | ||
| 38 | + # GH rest API has an undocumented limit of 65536 char for the body, setting it | ||
| 39 | + # to 65534 to account for the ellipsis and the final EOL. | ||
| 40 | + TEMP_BODY="$(awk -v MAX_BODY_LENGTH="65534" \ | ||
| 41 | + "/^## ${RELEASE_DATE}/,/^<a id=/{ | ||
| 42 | + if (/^<a id=/) {exit;} | ||
| 43 | + if ((output_length += length(\$0) + 1) > MAX_BODY_LENGTH) {exit 1;} | ||
| 44 | + print | ||
| 45 | + }" "doc/changelogs/CHANGELOG_V${RELEASE_LINE}.md" || echo "…")" | ||
| 41 | 46 | ||
| 42 | 47 | # Create the proposal branch | |
| 43 | 48 | gh api \ | |
0 commit comments