benchmark: use `cluster.isPrimary` instead of `cluster.isMaster` · nodejs/node@35c9615 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 35c9615

Browse filesBrowse the repository at this point in the historyBrowse files

deokjinkim

authored and

targos

committed

benchmark: use cluster.isPrimary instead of cluster.isMaster

`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary` for benchmark. Refs: #47981 PR-URL: #48002 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 6adaf4c commit 35c9615
Copy full SHA for 35c9615

2 files changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• benchmark
  • cluster
    • echo.js
  • http
    • cluster.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎benchmark/cluster/echo.js‎

Copy file name to clipboardExpand all lines: benchmark/cluster/echo.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1,7 +1,7 @@
1	1	'use strict';
2	2
3	3	const cluster = require('cluster');
4		- if (cluster.isMaster) {
	4	+ if (cluster.isPrimary) {
5	5	const common = require('../common.js');
6	6	const bench = common.createBenchmark(main, {
7	7	workers: [1],

Collapse file

‎benchmark/http/cluster.js‎

Copy file name to clipboardExpand all lines: benchmark/http/cluster.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -4,7 +4,7 @@ const PORT = common.PORT;
4	4
5	5	const cluster = require('cluster');
6	6	let bench;
7		- if (cluster.isMaster) {
	7	+ if (cluster.isPrimary) {
8	8	bench = common.createBenchmark(main, {
9	9	// Unicode confuses ab on os x.
10	10	type: ['bytes', 'buffer'],

0 commit comments

Comments

0 (0)