tools: align Bash snippets in GHA with `lint-sh` conventions · nodejs/node@363912a · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 637
• Pull requests 761
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 363912a

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

committed

tools: align Bash snippets in GHA with lint-sh conventions

Our shell scripts enforce passing arbitrary values via quoted env variables to avoid injections. Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #63829 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>

1 parent 28e3629 commit 363912a
Copy full SHA for 363912a

3 files changed

+11-6Lines changed: 11 additions & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• .github/workflows
  • comment-labeled.yml
  • label-flaky-test-issue.yml
  • linters.yml

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎.github/workflows/comment-labeled.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/comment-labeled.yml

+5-3Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -30,7 +30,7 @@ jobs:
30	30	env:
31	31	NUMBER: ${{ github.event.issue.number || github.event.pull_request.number }}
32	32	GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
33		- run: gh issue comment "$NUMBER" --repo ${{ github.repository }} --body "$STALE_MESSAGE"
	33	+ run: gh issue comment "$NUMBER" --repo "$GITHUB_REPOSITORY" --body "$STALE_MESSAGE"
34	34
35	35	fast-track:
36	36	permissions:
@@ -41,7 +41,8 @@ jobs:
41	41	- name: Request Fast-Track
42	42	env:
43	43	GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
44		- run: gh pr comment ${{ github.event.pull_request.number }} --repo ${{ github.repository }} --body "$FAST_TRACK_MESSAGE"
	44	+ NUMBER: ${{ github.event.pull_request.number }}
	45	+ run: gh pr comment "$NUMBER" --repo "$GITHUB_REPOSITORY" --body "$FAST_TRACK_MESSAGE"
45	46
46	47	notable-change:
47	48	permissions:
@@ -52,4 +53,5 @@ jobs:
52	53	- name: Add notable change description
53	54	env:
54	55	GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
55		- run: gh pr comment ${{ github.event.pull_request.number }} --repo ${{ github.repository }} --body "$NOTABLE_CHANGE_MESSAGE"
	56	+ NUMBER: ${{ github.event.pull_request.number }}
	57	+ run: gh pr comment "$NUMBER" --repo "$GITHUB_REPOSITORY" --body "$NOTABLE_CHANGE_MESSAGE"

Collapse file

‎.github/workflows/label-flaky-test-issue.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/label-flaky-test-issue.yml

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -49,4 +49,5 @@ jobs:
49	49	env:
50	50	GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
51	51	NUMBER: ${{ github.event.issue.number }}
52		- run: gh issue edit "$NUMBER" --repo ${{ github.repository }} --add-label "${{ steps.extract-labels.outputs.LABELS }}"
	52	+ LABELS: ${{ steps.extract-labels.outputs.LABELS }}
	53	+ run: gh issue edit "$NUMBER" --repo "$GITHUB_REPOSITORY" --add-label "$LABELS"

Collapse file

‎.github/workflows/linters.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/linters.yml

+4-2Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -252,8 +252,10 @@ jobs:
252	252	/tools/lint-pr-url.mjs
253	253	/doc/api/
254	254	sparse-checkout-cone-mode: false
255		- # GH Actions squashes all PR commits, HEAD^ refers to the base branch.
256		- - run: git diff HEAD^ HEAD -G"pr-url:" -- "*.md" | ./tools/lint-pr-url.mjs ${{ github.event.pull_request.html_url }}
	255	+ # We've checked out a merge commit, HEAD^ refers to the base branch.
	256	+ - run: git diff HEAD^ HEAD -G"pr-url:" -- "*.md" | ./tools/lint-pr-url.mjs "$PR_URL"
	257	+ env:
	258	+ PR_URL: ${{ github.event.pull_request.html_url }}
257	259	lint-readme:
258	260	runs-on: ubuntu-slim
259	261	steps:

0 commit comments

Comments

0 (0)