Revert "test: mark test-fs-watch-non-recursive flaky on Windows" · nodejs/node@36c9ea8 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 36c9ea8

Browse filesBrowse the repository at this point in the historyBrowse files

lpinca

authored and

targos

committed

Revert "test: mark test-fs-watch-non-recursive flaky on Windows"

This reverts commit 2a871df. It has been almost three years since the test was marked flaky. Remove the unstable designation to see if the problem persists on Windows. Fixes: #40728 PR-URL: #55079 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>

1 parent 566179c commit 36c9ea8
Copy full SHA for 36c9ea8

1 file changed

-2Lines changed: 0 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/pummel
  • pummel.status

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/pummel/pummel.status‎

Copy file name to clipboardExpand all lines: test/pummel/pummel.status

-2Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -7,8 +7,6 @@ prefix pummel
7	7	[true] # This section applies to all platforms
8	8
9	9	[$system==win32]
10		- # https://github.com/nodejs/node/issues/40728
11		- test-fs-watch-non-recursive: PASS,FLAKY
12	10
13	11	[$system==macos]
14	12

0 commit comments

Comments

0 (0)