Commit 3766e04
src: silence http2 -Wunused-result warnings
Backport-PR-URL: #18050
Backport-PR-URL: #20456
PR-URL: #17954
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent 35ee894 commit 3766e04
1 file changed
Lines changed: 11 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -560,13 +560,13 @@ inline void Http2Stream::EmitStatistics() { | |||
| 560 | 560 | FIXED_ONE_BYTE_STRING(env->isolate(), "timeToFirstByte"), | |
| 561 | 561 | Number::New(env->isolate(), | |
| 562 | 562 | (entry->first_byte() - entry->startTimeNano()) / 1e6), | |
| 563 | - attr); | ||
| 563 | + attr).FromJust(); | ||
| 564 | 564 | obj->DefineOwnProperty( | |
| 565 | 565 | context, | |
| 566 | 566 | FIXED_ONE_BYTE_STRING(env->isolate(), "timeToFirstHeader"), | |
| 567 | 567 | Number::New(env->isolate(), | |
| 568 | 568 | (entry->first_header() - entry->startTimeNano()) / 1e6), | |
| 569 | - attr); | ||
| 569 | + attr).FromJust(); | ||
| 570 | 570 | entry->Notify(obj); | |
| 571 | 571 | } | |
| 572 | 572 | delete entry; | |
@@ -592,25 +592,29 @@ inline void Http2Session::EmitStatistics() { | |||
| 592 | 592 | String::NewFromUtf8(env->isolate(), | |
| 593 | 593 | entry->typeName(), | |
| 594 | 594 | v8::NewStringType::kInternalized) | |
| 595 | - .ToLocalChecked(), attr); | ||
| 595 | + .ToLocalChecked(), attr).FromJust(); | ||
| 596 | 596 | if (entry->ping_rtt() != 0) { | |
| 597 | 597 | obj->DefineOwnProperty( | |
| 598 | 598 | context, | |
| 599 | 599 | FIXED_ONE_BYTE_STRING(env->isolate(), "pingRTT"), | |
| 600 | - Number::New(env->isolate(), entry->ping_rtt() / 1e6), attr); | ||
| 600 | + Number::New(env->isolate(), entry->ping_rtt() / 1e6), | ||
| 601 | + attr).FromJust(); | ||
| 601 | 602 | } | |
| 602 | 603 | obj->DefineOwnProperty( | |
| 603 | 604 | context, | |
| 604 | 605 | FIXED_ONE_BYTE_STRING(env->isolate(), "framesReceived"), | |
| 605 | - Integer::NewFromUnsigned(env->isolate(), entry->frame_count()), attr); | ||
| 606 | + Integer::NewFromUnsigned(env->isolate(), entry->frame_count()), | ||
| 607 | + attr).FromJust(); | ||
| 606 | 608 | obj->DefineOwnProperty( | |
| 607 | 609 | context, | |
| 608 | 610 | FIXED_ONE_BYTE_STRING(env->isolate(), "streamCount"), | |
| 609 | - Integer::New(env->isolate(), entry->stream_count()), attr); | ||
| 611 | + Integer::New(env->isolate(), entry->stream_count()), | ||
| 612 | + attr).FromJust(); | ||
| 610 | 613 | obj->DefineOwnProperty( | |
| 611 | 614 | context, | |
| 612 | 615 | FIXED_ONE_BYTE_STRING(env->isolate(), "streamAverageDuration"), | |
| 613 | - Number::New(env->isolate(), entry->stream_average_duration()), attr); | ||
| 616 | + Number::New(env->isolate(), entry->stream_average_duration()), | ||
| 617 | + attr).FromJust(); | ||
| 614 | 618 | entry->Notify(obj); | |
| 615 | 619 | } | |
| 616 | 620 | delete entry; | |
0 commit comments