Commit 377e8ce
tls: avoid external memory leak on invalid protocol versions
PR-URL: #60390
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>1 parent 4a5d7a4 commit 377e8ce
1 file changed
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -82,10 +82,11 @@ function SecureContext(secureProtocol, secureOptions, minVersion, maxVersion) { | |||
| 82 | 82 | throw new ERR_TLS_PROTOCOL_VERSION_CONFLICT(maxVersion, secureProtocol); | |
| 83 | 83 | } | |
| 84 | 84 | ||
| 85 | + const minV = toV('minimum', minVersion, tls.DEFAULT_MIN_VERSION); | ||
| 86 | + const maxV = toV('maximum', maxVersion, tls.DEFAULT_MAX_VERSION); | ||
| 87 | + | ||
| 85 | 88 | this.context = new NativeSecureContext(); | |
| 86 | - this.context.init(secureProtocol, | ||
| 87 | - toV('minimum', minVersion, tls.DEFAULT_MIN_VERSION), | ||
| 88 | - toV('maximum', maxVersion, tls.DEFAULT_MAX_VERSION)); | ||
| 89 | + this.context.init(secureProtocol, minV, maxV); | ||
| 89 | 90 | ||
| 90 | 91 | if (secureOptions) { | |
| 91 | 92 | validateInteger(secureOptions, 'secureOptions'); | |
0 commit comments