deps: disable trap handler for Windows cross-compiler · nodejs/node@37c9828 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 37c9828

Browse filesBrowse the repository at this point in the historyBrowse files

targos

committed

deps: disable trap handler for Windows cross-compiler

`handler-outside-simulator.cc` uses inline assembly, which is not supported by MSVC. PR-URL: #40488 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent dfb97fb commit 37c9828
Copy full SHA for 37c9828

2 files changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• common.gypi
• deps/v8/src/trap-handler
  • trap-handler.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -36,7 +36,7 @@
36	36
37	37	# Reset this number to 0 on major V8 upgrades.
38	38	# Increment by one for each non-official patch applied to deps/v8.
39		- 'v8_embedder_string': '-node.7',
	39	+ 'v8_embedder_string': '-node.8',
40	40
41	41	##### V8 defaults for Node.js #####
42	42

Collapse file

‎deps/v8/src/trap-handler/trap-handler.h‎

Copy file name to clipboardExpand all lines: deps/v8/src/trap-handler/trap-handler.h

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -27,7 +27,7 @@ namespace trap_handler {
27	27	#define V8_TRAP_HANDLER_SUPPORTED true
28	28	// Arm64 simulator on x64 on Linux, Mac, or Windows.
29	29	#elif V8_TARGET_ARCH_ARM64 && V8_HOST_ARCH_X64 && \
30		- (V8_OS_LINUX || V8_OS_MACOSX || V8_OS_WIN)
	30	+ (V8_OS_LINUX || V8_OS_MACOSX)
31	31	#define V8_TRAP_HANDLER_VIA_SIMULATOR
32	32	#define V8_TRAP_HANDLER_SUPPORTED true
33	33	// Everything else is unsupported.

0 commit comments

Comments

0 (0)