Revert "tools: fix compiler warning in inspector_protocol" · nodejs/node@383fa01 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 383fa01

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

targos

committed

Revert "tools: fix compiler warning in inspector_protocol"

This reverts commit ffb34b6. PR-URL: #39694 Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent b95a759 commit 383fa01
Copy full SHA for 383fa01

2 files changed

+4-6Lines changed: 4 additions & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tools/inspector_protocol
  • encoding
    • encoding.cc
  • lib
    • encoding_cpp.template

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tools/inspector_protocol/encoding/encoding.cc‎

Copy file name to clipboardExpand all lines: tools/inspector_protocol/encoding/encoding.cc

+2-3Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -833,9 +833,8 @@ void CBORTokenizer::ReadNextToken(bool enter_envelope) {
833	833	// inspector_protocol, it's not a CBOR limitation), so we check
834	834	// against the signed max, so that the allowable values are
835	835	// 0, 1, 2, ... 2^31 - 1.
836		- if (!success ||
837		- static_cast<int64_t>(std::numeric_limits<int32_t>::max()) <
838		- static_cast<int64_t>(token_start_internal_value_)) {
	836	+ if (!success || std::numeric_limits<int32_t>::max() <
	837	+ token_start_internal_value_) {
839	838	SetError(Error::CBOR_INVALID_INT32);
840	839	return;
841	840	}

Collapse file

‎tools/inspector_protocol/lib/encoding_cpp.template‎

Copy file name to clipboardExpand all lines: tools/inspector_protocol/lib/encoding_cpp.template

+2-3Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -840,9 +840,8 @@ void CBORTokenizer::ReadNextToken(bool enter_envelope) {
840	840	// inspector_protocol, it's not a CBOR limitation), so we check
841	841	// against the signed max, so that the allowable values are
842	842	// 0, 1, 2, ... 2^31 - 1.
843		- if (!success ||
844		- static_cast<int64_t>(std::numeric_limits<int32_t>::max()) <
845		- static_cast<int64_t>(token_start_internal_value_)) {
	843	+ if (!success || std::numeric_limits<int32_t>::max() <
	844	+ token_start_internal_value_) {
846	845	SetError(Error::CBOR_INVALID_INT32);
847	846	return;
848	847	}

0 commit comments

Comments

0 (0)