Commit 38bafc5
deps: V8: backport 493cb53691be
Original commit message:
[include] suppress clang cast-function-type-mismatch warning on SetWeak
Suppress clang warning cast-function-type-mismatch in embedder calls
to `SetWeak`.
Change-Id: I6c4eda1b932199a2ea4947fe851ffdf2ae04ad73
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6689209
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Chengzhong Wu <cwu631@bloomberg.net>
Cr-Commit-Position: refs/heads/main@{#101186}
Ignore `cast-function-type` instead of `cast-function-type-mismatch` for
compatibility with older versions of Clang.
Refs: v8/v8@493cb53
PR-URL: #59238
Refs: #58069
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>1 parent 6590023 commit 38bafc5
2 files changed
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -38,7 +38,7 @@ | |||
| 38 | 38 | ||
| 39 | 39 | # Reset this number to 0 on major V8 upgrades. | |
| 40 | 40 | # Increment by one for each non-official patch applied to deps/v8. | |
| 41 | - 'v8_embedder_string': '-node.27', | ||
| 41 | + 'v8_embedder_string': '-node.28', | ||
| 42 | 42 | ||
| 43 | 43 | ##### V8 defaults for Node.js ##### | |
| 44 | 44 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -507,9 +507,16 @@ V8_INLINE void PersistentBase<T>::SetWeak( | |||
| 507 | 507 | #if (__GNUC__ >= 8) && !defined(__clang__) | |
| 508 | 508 | #pragma GCC diagnostic push | |
| 509 | 509 | #pragma GCC diagnostic ignored "-Wcast-function-type" | |
| 510 | + #endif | ||
| 511 | + #if __clang__ | ||
| 512 | + #pragma clang diagnostic push | ||
| 513 | + #pragma clang diagnostic ignored "-Wcast-function-type" | ||
| 510 | 514 | #endif | |
| 511 | 515 | api_internal::MakeWeak(this->slot(), parameter, | |
| 512 | 516 | reinterpret_cast<Callback>(callback), type); | |
| 517 | + #if __clang__ | ||
| 518 | + #pragma clang diagnostic pop | ||
| 519 | + #endif | ||
| 513 | 520 | #if (__GNUC__ >= 8) && !defined(__clang__) | |
| 514 | 521 | #pragma GCC diagnostic pop | |
| 515 | 522 | #endif | |
0 commit comments