Commit 38bb0d8
tools: Use throw new Error() consistently
In preparation for a lint rule that will enforce `throw new Error()`
over `throw Error()`, fix the handful of instances in the code that
use `throw Error()`.
PR-URL: #3714
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 02e012e commit 38bb0d8
5 files changed
Lines changed: 6 additions & 6 deletions
File tree
- test
- addons/make-callback
- parallel
- pummel
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -40,7 +40,7 @@ assert.strictEqual(42, makeCallback(recv, 'two', 1337)); | |||
| 40 | 40 | const target = vm.runInNewContext(` | |
| 41 | 41 | (function($Object) { | |
| 42 | 42 | if (Object === $Object) | |
| 43 | - throw Error('bad'); | ||
| 43 | + throw new Error('bad'); | ||
| 44 | 44 | return Object; | |
| 45 | 45 | }) | |
| 46 | 46 | `); | |
@@ -55,7 +55,7 @@ const forward = vm.runInNewContext(` | |||
| 55 | 55 | // Runs in outer context. | |
| 56 | 56 | const endpoint = function($Object) { | |
| 57 | 57 | if (Object === $Object) | |
| 58 | - throw Error('bad'); | ||
| 58 | + throw new Error('bad'); | ||
| 59 | 59 | return Object; | |
| 60 | 60 | }; | |
| 61 | 61 | assert.strictEqual(Object, makeCallback(process, forward, endpoint)); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -465,6 +465,6 @@ testBlockTypeError(assert.doesNotThrow, undefined); | |||
| 465 | 465 | ||
| 466 | 466 | // https://github.com/nodejs/node/issues/3275 | |
| 467 | 467 | assert.throws(() => { throw 'error'; }, err => err === 'error'); | |
| 468 | - assert.throws(() => { throw Error(); }, err => err instanceof Error); | ||
| 468 | + assert.throws(() => { throw new Error(); }, err => err instanceof Error); | ||
| 469 | 469 | ||
| 470 | 470 | console.log('All OK'); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -110,7 +110,7 @@ function nextTest() { | |||
| 110 | 110 | break; | |
| 111 | 111 | ||
| 112 | 112 | default: | |
| 113 | - throw Error('?'); | ||
| 113 | + throw new Error('?'); | ||
| 114 | 114 | } | |
| 115 | 115 | ||
| 116 | 116 | response.setEncoding('utf8'); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -46,7 +46,7 @@ var timeToQuit = Date.now() + 8e3; //Test during no more than this seconds. | |||
| 46 | 46 | } | |
| 47 | 47 | } | |
| 48 | 48 | else { | |
| 49 | - throw Error("Buffer GC'ed test -> FAIL"); | ||
| 49 | + throw new Error("Buffer GC'ed test -> FAIL"); | ||
| 50 | 50 | } | |
| 51 | 51 | ||
| 52 | 52 | if (Date.now() < timeToQuit) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -21,7 +21,7 @@ function tailCB(data) { | |||
| 21 | 21 | console.error('[FAIL]\n DATA -> '); | |
| 22 | 22 | console.error(data); | |
| 23 | 23 | console.error('\n'); | |
| 24 | - throw Error('Buffers GC test -> FAIL'); | ||
| 24 | + throw new Error('Buffers GC test -> FAIL'); | ||
| 25 | 25 | } | |
| 26 | 26 | } | |
| 27 | 27 | ||
0 commit comments