Commit 38cfb70
http2: don't call into JS from GC
Calling into JS land from GC is not allowed, so delay
the resolution of pending pings when a session is destroyed.
Backport-PR-URL: #18050
Backport-PR-URL: #20456
PR-URL: #17183
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>1 parent 2b77327 commit 38cfb70
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -406,7 +406,11 @@ void Http2Session::Close() { | |||
| 406 | 406 | ||
| 407 | 407 | while (!outstanding_pings_.empty()) { | |
| 408 | 408 | Http2Session::Http2Ping* ping = PopPing(); | |
| 409 | - ping->Done(false); | ||
| 409 | + // Since this method may be called from GC, calling into JS directly | ||
| 410 | + // is not allowed. | ||
| 411 | + env()->SetImmediate([](Environment* env, void* data) { | ||
| 412 | + static_cast<Http2Session::Http2Ping*>(data)->Done(false); | ||
| 413 | + }, static_cast<void*>(ping)); | ||
| 410 | 414 | } | |
| 411 | 415 | ||
| 412 | 416 | Stop(); | |
0 commit comments