Commit 3906206
net: remove unnecessary variables
V8 is smart enough to optimize the length property checking when
iterating over an array with a for loop.
PR-URL: #8112
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent b063dc9 commit 3906206
1 file changed
Lines changed: 4 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -59,9 +59,8 @@ exports.createServer = function(options, connectionListener) { | |||
| 59 | 59 | // connect(path, [cb]); | |
| 60 | 60 | // | |
| 61 | 61 | exports.connect = exports.createConnection = function() { | |
| 62 | - const argsLen = arguments.length; | ||
| 63 | - var args = new Array(argsLen); | ||
| 64 | - for (var i = 0; i < argsLen; i++) | ||
| 62 | + var args = new Array(arguments.length); | ||
| 63 | + for (var i = 0; i < arguments.length; i++) | ||
| 65 | 64 | args[i] = arguments[i]; | |
| 66 | 65 | args = normalizeConnectArgs(args); | |
| 67 | 66 | debug('createConnection', args); | |
@@ -875,9 +874,8 @@ Socket.prototype.connect = function(options, cb) { | |||
| 875 | 874 | // Old API: | |
| 876 | 875 | // connect(port, [host], [cb]) | |
| 877 | 876 | // connect(path, [cb]); | |
| 878 | - const argsLen = arguments.length; | ||
| 879 | - var args = new Array(argsLen); | ||
| 880 | - for (var i = 0; i < argsLen; i++) | ||
| 877 | + var args = new Array(arguments.length); | ||
| 878 | + for (var i = 0; i < arguments.length; i++) | ||
| 881 | 879 | args[i] = arguments[i]; | |
| 882 | 880 | args = normalizeConnectArgs(args); | |
| 883 | 881 | return Socket.prototype.connect.apply(this, args); | |
0 commit comments