test: make node-api/test_buffer/test_finalizer not flaky · nodejs/node@3948acc · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 637
• Pull requests 758
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 3948acc

Browse filesBrowse the repository at this point in the historyBrowse files

mcollina

authored and

targos

committed

test: make node-api/test_buffer/test_finalizer not flaky

PR-URL: #43418 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

1 parent 58646ea commit 3948acc
Copy full SHA for 3948acc

1 file changed

+5-1Lines changed: 5 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/node-api/test_buffer
  • test_finalizer.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/node-api/test_buffer/test_finalizer.js‎

Copy file name to clipboardExpand all lines: test/node-api/test_buffer/test_finalizer.js

+5-1Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -16,6 +16,10 @@ process.on('uncaughtException', common.mustCall((err) => {
16	16	throw new Error('finalizer error');
17	17	}));
18	18	}
	19	+ global.gc(true);
	20	+ await tick(common.platformTimeout(100));
19	21	global.gc();
20		- await tick(10);
	22	+ await tick(common.platformTimeout(100));
	23	+ global.gc();
	24	+ await tick(common.platformTimeout(100));
21	25	})().then(common.mustCall());

0 commit comments

Comments

0 (0)