src: do not rely on the internal field being default to undefined · nodejs/node@39fb83a · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 39fb83a

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

ruyadorno

committed

src: do not rely on the internal field being default to undefined

It's an undocumented V8 behavior that is subject to change. Instead just check if the internal field is set to a promise. There is also no need to check IsEmpty() since the object is guaranteed to be constructed by the FileHandle constructor with enough internal fields. PR-URL: #49413 Refs: https://chromium-review.googlesource.com/c/v8/v8/+/4707972/comment/be9285cc_a49aad88/ Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

1 parent 3987094 commit 39fb83a
Copy full SHA for 39fb83a

1 file changed

+1-2Lines changed: 1 addition & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_file.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_file.cc‎

Copy file name to clipboardExpand all lines: src/node_file.cc

+1-2Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -457,8 +457,7 @@ MaybeLocal<Promise> FileHandle::ClosePromise() {
457	457
458	458	Local<Value> close_resolver =
459	459	object()->GetInternalField(FileHandle::kClosingPromiseSlot).As<Value>();
460		- if (!close_resolver.IsEmpty() && !close_resolver->IsUndefined()) {
461		- CHECK(close_resolver->IsPromise());
	460	+ if (close_resolver->IsPromise()) {
462	461	return close_resolver.As<Promise>();
463	462	}
464	463

0 commit comments

Comments

0 (0)