Commit 3a60de0
assert: change status of legacy asserts
Previously marked deprecated, but these are unlikely to ever see
breaking changes or complete removal. Mark as legacy instead.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #38113
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>1 parent d0d731e commit 3a60de0
1 file changed
Lines changed: 20 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -304,6 +304,10 @@ An alias of [`assert.ok()`][]. | |||
| 304 | 304 | <!-- YAML | |
| 305 | 305 | added: v0.1.21 | |
| 306 | 306 | changes: | |
| 307 | + - version: REPLACEME | ||
| 308 | + pr-url: https://github.com/nodejs/node/pull/38113 | ||
| 309 | + description: In Legacy assertion mode, changed status from Deprecated to | ||
| 310 | + Legacy. | ||
| 307 | 311 | - version: v14.0.0 | |
| 308 | 312 | pr-url: https://github.com/nodejs/node/pull/30766 | |
| 309 | 313 | description: NaN is now treated as being identical in case both sides are | |
@@ -345,7 +349,7 @@ An alias of [`assert.deepStrictEqual()`][]. | |||
| 345 | 349 | ||
| 346 | 350 | **Legacy assertion mode** | |
| 347 | 351 | ||
| 348 | - > Stability: 0 - Deprecated: Use [`assert.deepStrictEqual()`][] instead. | ||
| 352 | + > Stability: 3 - Legacy: Use [`assert.deepStrictEqual()`][] instead. | ||
| 349 | 353 | ||
| 350 | 354 | Tests for deep equality between the `actual` and `expected` parameters. Consider | |
| 351 | 355 | using [`assert.deepStrictEqual()`][] instead. [`assert.deepEqual()`][] can have | |
@@ -754,6 +758,10 @@ assert.doesNotThrow( | |||
| 754 | 758 | <!-- YAML | |
| 755 | 759 | added: v0.1.21 | |
| 756 | 760 | changes: | |
| 761 | + - version: REPLACEME | ||
| 762 | + pr-url: https://github.com/nodejs/node/pull/38113 | ||
| 763 | + description: In Legacy assertion mode, changed status from Deprecated to | ||
| 764 | + Legacy. | ||
| 757 | 765 | - version: v14.0.0 | |
| 758 | 766 | pr-url: https://github.com/nodejs/node/pull/30766 | |
| 759 | 767 | description: NaN is now treated as being identical in case both sides are | |
@@ -770,7 +778,7 @@ An alias of [`assert.strictEqual()`][]. | |||
| 770 | 778 | ||
| 771 | 779 | **Legacy assertion mode** | |
| 772 | 780 | ||
| 773 | - > Stability: 0 - Deprecated: Use [`assert.strictEqual()`][] instead. | ||
| 781 | + > Stability: 3 - Legacy: Use [`assert.strictEqual()`][] instead. | ||
| 774 | 782 | ||
| 775 | 783 | Tests shallow, coercive equality between the `actual` and `expected` parameters | |
| 776 | 784 | using the [Abstract Equality Comparison][] ( `==` ). `NaN` is special handled | |
@@ -977,6 +985,10 @@ instance of an [`Error`][] then it will be thrown instead of the | |||
| 977 | 985 | <!-- YAML | |
| 978 | 986 | added: v0.1.21 | |
| 979 | 987 | changes: | |
| 988 | + - version: REPLACEME | ||
| 989 | + pr-url: https://github.com/nodejs/node/pull/38113 | ||
| 990 | + description: In Legacy assertion mode, changed status from Deprecated to | ||
| 991 | + Legacy. | ||
| 980 | 992 | - version: v14.0.0 | |
| 981 | 993 | pr-url: https://github.com/nodejs/node/pull/30766 | |
| 982 | 994 | description: NaN is now treated as being identical in case both sides are | |
@@ -1014,7 +1026,7 @@ An alias of [`assert.notDeepStrictEqual()`][]. | |||
| 1014 | 1026 | ||
| 1015 | 1027 | **Legacy assertion mode** | |
| 1016 | 1028 | ||
| 1017 | - > Stability: 0 - Deprecated: Use [`assert.notDeepStrictEqual()`][] instead. | ||
| 1029 | + > Stability: 3 - Legacy: Use [`assert.notDeepStrictEqual()`][] instead. | ||
| 1018 | 1030 | ||
| 1019 | 1031 | Tests for any deep inequality. Opposite of [`assert.deepEqual()`][]. | |
| 1020 | 1032 | ||
@@ -1113,6 +1125,10 @@ instead of the [`AssertionError`][]. | |||
| 1113 | 1125 | <!-- YAML | |
| 1114 | 1126 | added: v0.1.21 | |
| 1115 | 1127 | changes: | |
| 1128 | + - version: REPLACEME | ||
| 1129 | + pr-url: https://github.com/nodejs/node/pull/38113 | ||
| 1130 | + description: In Legacy assertion mode, changed status from Deprecated to | ||
| 1131 | + Legacy. | ||
| 1116 | 1132 | - version: v14.0.0 | |
| 1117 | 1133 | pr-url: https://github.com/nodejs/node/pull/30766 | |
| 1118 | 1134 | description: NaN is now treated as being identical in case both sides are | |
@@ -1129,7 +1145,7 @@ An alias of [`assert.notStrictEqual()`][]. | |||
| 1129 | 1145 | ||
| 1130 | 1146 | **Legacy assertion mode** | |
| 1131 | 1147 | ||
| 1132 | - > Stability: 0 - Deprecated: Use [`assert.notStrictEqual()`][] instead. | ||
| 1148 | + > Stability: 3 - Legacy: Use [`assert.notStrictEqual()`][] instead. | ||
| 1133 | 1149 | ||
| 1134 | 1150 | Tests shallow, coercive inequality with the [Abstract Equality Comparison][] | |
| 1135 | 1151 | (`!=` ). `NaN` is special handled and treated as being identical in case both | |
0 commit comments