Commit 3ab070d
deps: backport dfb8d33 from V8 upstream
Original commit message:
Reduce the memory footprint of expression classifiers
This patch attempts to reduce the (stack) memory footprint of
expression classifiers. Instead of keeping space in each
classifier for all possible error messages that will
(potentially) be reported, if an expression turns out to be
a pattern or a non-pattern, such error messages are placed in
a list shared by the FunctionState and each classifier keeps a
couple of indices in this list. This requires that classifiers
are used strictly in a stack-based fashion, which is also in line
with my previous patch for revisiting non-pattern rewriting.
R=adamk@chromium.org
BUG=chromium:528697
Review-Url: https://codereview.chromium.org/1708193003
Cr-Commit-Position: refs/heads/master@{#36897}
Fixes: #11480
PR-URL: #11483
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>1 parent b5fb9f4 commit 3ab070d
7 files changed
Lines changed: 288 additions & 157 deletions
File tree
- deps/v8
- include
- src
- parsing
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -11,7 +11,7 @@ | |||
| 11 | 11 | #define V8_MAJOR_VERSION 5 | |
| 12 | 12 | #define V8_MINOR_VERSION 1 | |
| 13 | 13 | #define V8_BUILD_NUMBER 281 | |
| 14 | - #define V8_PATCH_LEVEL 94 | ||
| 14 | + #define V8_PATCH_LEVEL 95 | ||
| 15 | 15 | ||
| 16 | 16 | // Use 1 for candidates and 0 otherwise. | |
| 17 | 17 | // (Boolean macro values are not supported by all preprocessors.) | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -449,6 +449,8 @@ class CallSite { | |||
| 449 | 449 | "Too many arguments in function call (only 65535 allowed)") \ | |
| 450 | 450 | T(TooManyParameters, \ | |
| 451 | 451 | "Too many parameters in function definition (only 65535 allowed)") \ | |
| 452 | + T(TooManySpreads, \ | ||
| 453 | + "Literal containing too many nested spreads (up to 65534 allowed)") \ | ||
| 452 | 454 | T(TooManyVariables, "Too many variables declared (only 4194303 allowed)") \ | |
| 453 | 455 | T(TypedArrayTooShort, \ | |
| 454 | 456 | "Derived TypedArray constructor created an array which was too small") \ | |
0 commit comments