Commit 3b096c2
build,win: propagate error codes in vcbuild
Don't exit vcbuild with error code 0 when cctest fails.
PR-URL: #30724
Refs: nodejs/build#1996
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 6a35c38 commit 3b096c2
1 file changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -68,6 +68,7 @@ set cctest= | |||
| 68 | 68 | set openssl_no_asm= | |
| 69 | 69 | set doc= | |
| 70 | 70 | set extra_msbuild_args= | |
| 71 | + set exit_code=0 | ||
| 71 | 72 | ||
| 72 | 73 | :next-arg | |
| 73 | 74 | if "%1"=="" goto args-done | |
@@ -629,9 +630,11 @@ if defined no_cctest echo Skipping cctest because no-cctest was specified && got | |||
| 629 | 630 | if not exist "%config%\cctest.exe" echo cctest.exe not found. Run "vcbuild test" or "vcbuild cctest" to build it. && goto run-test-py | |
| 630 | 631 | echo running 'cctest %cctest_args%' | |
| 631 | 632 | "%config%\cctest" %cctest_args% | |
| 633 | + if %errorlevel% neq 0 set exit_code=%errorlevel% | ||
| 632 | 634 | :run-test-py | |
| 633 | 635 | echo running 'python tools\test.py %test_args%' | |
| 634 | 636 | python tools\test.py %test_args% | |
| 637 | + if %errorlevel% neq 0 set exit_code=%errorlevel% | ||
| 635 | 638 | goto test-v8 | |
| 636 | 639 | ||
| 637 | 640 | :test-v8 | |
@@ -714,7 +717,7 @@ echo vcbuild.bat no-cctest : skip building cctest.exe | |||
| 714 | 717 | goto exit | |
| 715 | 718 | ||
| 716 | 719 | :exit | |
| 717 | - goto :EOF | ||
| 720 | + exit /b %exit_code% | ||
| 718 | 721 | ||
| 719 | 722 | ||
| 720 | 723 | rem *************** | |
0 commit comments