Commit 3b22520
test: fs.link() test runs on same device
When running the tests if `NODE_TEST_DIR` is set to a device different
than the location of the test files (where this repo is checked out),
then the parallel/test-fs-link.js test will fail with
`EXDEV: cross-device link not permitted`. The code works fine (and is in
fact throwing an error as desired) but the test fails.
This commit first creates the "source" file in the same directory as the
"destination" (where the hardlink will be created).
PR-URL: #4861
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 1860eae commit 3b22520
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -7,14 +7,14 @@ const fs = require('fs'); | |||
| 7 | 7 | common.refreshTmpDir(); | |
| 8 | 8 | ||
| 9 | 9 | // test creating and reading hard link | |
| 10 | - const srcPath = path.join(common.fixturesDir, 'cycles', 'root.js'); | ||
| 10 | + const srcPath = path.join(common.tmpDir, 'hardlink-target.txt'); | ||
| 11 | 11 | const dstPath = path.join(common.tmpDir, 'link1.js'); | |
| 12 | + fs.writeFileSync(srcPath, 'hello world'); | ||
| 12 | 13 | ||
| 13 | 14 | const callback = function(err) { | |
| 14 | 15 | if (err) throw err; | |
| 15 | - const srcContent = fs.readFileSync(srcPath, 'utf8'); | ||
| 16 | 16 | const dstContent = fs.readFileSync(dstPath, 'utf8'); | |
| 17 | - assert.strictEqual(srcContent, dstContent); | ||
| 17 | + assert.strictEqual('hello world', dstContent); | ||
| 18 | 18 | }; | |
| 19 | 19 | ||
| 20 | 20 | fs.link(srcPath, dstPath, common.mustCall(callback)); | |
0 commit comments