lib: filter node:quic from builtinModules when flag not used · nodejs/node@3b305f2 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 748
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 3b305f2

Browse filesBrowse the repository at this point in the historyBrowse files

jasnell

authored and

targos

committed

lib: filter node:quic from builtinModules when flag not used

PR-URL: #56870 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

1 parent 94a0237 commit 3b305f2
Copy full SHA for 3b305f2

1 file changed

+5-1Lines changed: 5 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/modules/cjs
  • loader.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/modules/cjs/loader.js‎

Copy file name to clipboardExpand all lines: lib/internal/modules/cjs/loader.js

+5-1Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -435,7 +435,11 @@ Module.isBuiltin = BuiltinModule.isBuiltin;
435	435	function initializeCJS() {
436	436	// This need to be done at runtime in case --expose-internals is set.
437	437
438		- Module.builtinModules = ObjectFreeze(BuiltinModule.getAllBuiltinModuleIds());
	438	+ let modules = Module.builtinModules = BuiltinModule.getAllBuiltinModuleIds();
	439	+ if (!getOptionValue('--experimental-quic')) {
	440	+ modules = modules.filter((i) => i !== 'node:quic');
	441	+ }
	442	+ Module.builtinModules = ObjectFreeze(modules);
439	443
440	444	initializeCjsConditions();
441	445

0 commit comments

Comments

0 (0)