Commit 3b6cf09
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -52,7 +52,7 @@ documented [on the V8 wiki][V8MergingPatching]. The summary of the process is: | |||
| 52 | 52 | ||
| 53 | 53 | At any given time Node.js needs to be maintaining a few different V8 branches | |
| 54 | 54 | for the various Current, LTS, and nightly releases. At present this list | |
| 55 | - includes the following branches<sup>1</sup>: | ||
| 55 | + includes the following branches:[^1] | ||
| 56 | 56 | ||
| 57 | 57 | <table> | |
| 58 | 58 | <tr> | |
@@ -222,7 +222,7 @@ to be cherry-picked in the Node.js repository and V8-CI must test the change. | |||
| 222 | 222 | * Run the Node.js [V8 CI][] in addition to the [Node.js CI][]. | |
| 223 | 223 | The CI uses the `test-v8` target in the `Makefile`, which uses | |
| 224 | 224 | `tools/make-v8.sh` to reconstruct a git tree in the `deps/v8` directory to | |
| 225 | - run V8 tests<sup>2</sup>. | ||
| 225 | + run V8 tests.[^2] | ||
| 226 | 226 | ||
| 227 | 227 | The [`git-node`][] tool can be used to simplify this task. Run | |
| 228 | 228 | `git node v8 backport <sha>` to cherry-pick a commit. | |
@@ -404,17 +404,13 @@ This would require some tooling to: | |||
| 404 | 404 | promoted from `nodejs/v8` to `nodejs/node`. | |
| 405 | 405 | * Enabled the V8-CI build in Jenkins to build from the `nodejs/v8` fork. | |
| 406 | 406 | ||
| 407 | - <!-- Footnotes themselves at the bottom. --> | ||
| 407 | + [^1]: Node.js 0.12 and older are intentionally omitted from this document | ||
| 408 | + as their support has ended. | ||
| 408 | 409 | ||
| 409 | - ### Notes | ||
| 410 | - | ||
| 411 | - <sup>1</sup>Node.js 0.12 and older are intentionally omitted from this document | ||
| 412 | - as their support has ended. | ||
| 413 | - | ||
| 414 | - <sup>2</sup>The V8 tests still require Python 2. To run these tests locally, | ||
| 415 | - you can run `PYTHON2 ./configure.py` before running `make test-v8`, in the root | ||
| 416 | - of this repository. On macOS, this also requires a full Xcode install, | ||
| 417 | - not just the "command line tools" for Xcode. | ||
| 410 | + [^2]: The V8 tests still require Python 2. To run these tests locally, you can | ||
| 411 | + run `PYTHON2 ./configure.py` before running `make test-v8`, in the root | ||
| 412 | + of this repository. On macOS, this also requires a full Xcode install, | ||
| 413 | + not just the "command line tools" for Xcode. | ||
| 418 | 414 | ||
| 419 | 415 | [ChromiumReleaseCalendar]: https://www.chromium.org/developers/calendar | |
| 420 | 416 | [Node.js CI]: https://ci.nodejs.org/job/node-test-pull-request/ | |
0 commit comments