FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: add a couple fast apis in node_os · nodejs/node@3b8d4e3 · GitHub

/ node Public

Commit 3b8d4e3

Browse files
jasnell
authored and
targos
committed
src: add a couple fast apis in node_os
PR-URL: #58210 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
1 parent 290a5ab commit 3b8d4e3

3 files changed

Lines changed: 71 additions & 4 deletions

File tree

‎src/node_external_reference.h‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,8 @@ using CFunctionCallbackWithUint8ArrayUint32Int64Bool =
6666
v8::FastApiCallbackOptions&);
6767
using CFunctionWithUint32 = uint32_t (*)(v8::Local<v8::Value>,
6868
const uint32_t input);
69+
using CFunctionWithReturnUint32 = uint32_t (*)(v8::Local<v8::Value>);
70+
using CFunctionWithReturnDouble = double (*)(v8::Local<v8::Value>);
6971
using CFunctionWithDoubleReturnDouble = double (*)(v8::Local<v8::Value>,
7072
v8::Local<v8::Value>,
7173
const double);
@@ -107,6 +109,7 @@ class ExternalReferenceRegistry {
107109
V(CFunctionCallbackReturnBool) \
108110
V(CFunctionCallbackReturnDouble) \
109111
V(CFunctionCallbackReturnInt32) \
112+
V(CFunctionWithReturnUint32) \
110113
V(CFunctionCallbackValueReturnDouble) \
111114
V(CFunctionCallbackValueReturnDoubleUnusedReceiver) \
112115
V(CFunctionCallbackWithInt64) \

‎src/node_os.cc‎

Lines changed: 38 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
// USE OR OTHER DEALINGS IN THE SOFTWARE.
2121

2222
#include "env-inl.h"
23+
#include "node_debug.h"
2324
#include "node_external_reference.h"
2425
#include "string_bytes.h"
2526

@@ -148,12 +149,26 @@ static void GetFreeMemory(const FunctionCallbackInfo<Value>& args) {
148149
args.GetReturnValue().Set(amount);
149150
}
150151

152+
static double FastGetFreeMemory(Local<Value> receiver) {
153+
TRACK_V8_FAST_API_CALL("os.freemem");
154+
return static_cast<double>(uv_get_free_memory());
155+
}
156+
157+
static v8::CFunction fast_get_free_memory(
158+
v8::CFunction::Make(FastGetFreeMemory));
151159

152160
static void GetTotalMemory(const FunctionCallbackInfo<Value>& args) {
153161
double amount = static_cast<double>(uv_get_total_memory());
154162
args.GetReturnValue().Set(amount);
155163
}
156164

165+
double FastGetTotalMemory(Local<Value> receiver) {
166+
TRACK_V8_FAST_API_CALL("os.totalmem");
167+
return static_cast<double>(uv_get_total_memory());
168+
}
169+
170+
static v8::CFunction fast_get_total_memory(
171+
v8::CFunction::Make(FastGetTotalMemory));
157172

158173
static void GetUptime(const FunctionCallbackInfo<Value>& args) {
159174
Environment* env = Environment::GetCurrent(args);
@@ -398,6 +413,14 @@ static void GetAvailableParallelism(const FunctionCallbackInfo<Value>& args) {
398413
args.GetReturnValue().Set(parallelism);
399414
}
400415

416+
uint32_t FastGetAvailableParallelism(v8::Local<v8::Value> receiver) {
417+
TRACK_V8_FAST_API_CALL("os.availableParallelism");
418+
return uv_available_parallelism();
419+
}
420+
421+
static v8::CFunction fast_get_available_parallelism(
422+
v8::CFunction::Make(FastGetAvailableParallelism));
423+
401424
void Initialize(Local<Object> target,
402425
Local<Value> unused,
403426
Local<Context> context,
@@ -406,16 +429,21 @@ void Initialize(Local<Object> target,
406429
SetMethod(context, target, "getHostname", GetHostname);
407430
SetMethod(context, target, "getLoadAvg", GetLoadAvg);
408431
SetMethod(context, target, "getUptime", GetUptime);
409-
SetMethod(context, target, "getTotalMem", GetTotalMemory);
410-
SetMethod(context, target, "getFreeMem", GetFreeMemory);
432+
SetFastMethodNoSideEffect(
433+
context, target, "getTotalMem", GetTotalMemory, &fast_get_total_memory);
434+
SetFastMethodNoSideEffect(
435+
context, target, "getFreeMem", GetFreeMemory, &fast_get_free_memory);
411436
SetMethod(context, target, "getCPUs", GetCPUInfo);
412437
SetMethod(context, target, "getInterfaceAddresses", GetInterfaceAddresses);
413438
SetMethod(context, target, "getHomeDirectory", GetHomeDirectory);
414439
SetMethod(context, target, "getUserInfo", GetUserInfo);
415440
SetMethod(context, target, "setPriority", SetPriority);
416441
SetMethod(context, target, "getPriority", GetPriority);
417-
SetMethod(
418-
context, target, "getAvailableParallelism", GetAvailableParallelism);
442+
SetFastMethodNoSideEffect(context,
443+
target,
444+
"getAvailableParallelism",
445+
GetAvailableParallelism,
446+
&fast_get_available_parallelism);
419447
SetMethod(context, target, "getOSInformation", GetOSInformation);
420448
target
421449
->Set(context,
@@ -429,14 +457,20 @@ void RegisterExternalReferences(ExternalReferenceRegistry* registry) {
429457
registry->Register(GetLoadAvg);
430458
registry->Register(GetUptime);
431459
registry->Register(GetTotalMemory);
460+
registry->Register(FastGetTotalMemory);
461+
registry->Register(fast_get_total_memory.GetTypeInfo());
432462
registry->Register(GetFreeMemory);
463+
registry->Register(FastGetFreeMemory);
464+
registry->Register(fast_get_free_memory.GetTypeInfo());
433465
registry->Register(GetCPUInfo);
434466
registry->Register(GetInterfaceAddresses);
435467
registry->Register(GetHomeDirectory);
436468
registry->Register(GetUserInfo);
437469
registry->Register(SetPriority);
438470
registry->Register(GetPriority);
439471
registry->Register(GetAvailableParallelism);
472+
registry->Register(FastGetAvailableParallelism);
473+
registry->Register(fast_get_available_parallelism.GetTypeInfo());
440474
registry->Register(GetOSInformation);
441475
}
442476

‎test/parallel/test-os-fast.js‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
// Flags: --expose-internals --no-warnings --allow-natives-syntax
2+
'use strict';
3+
4+
const common = require('../common');
5+
const assert = require('assert');
6+
const {
7+
totalmem,
8+
freemem,
9+
availableParallelism,
10+
} = require('os');
11+
12+
const { internalBinding } = require('internal/test/binding');
13+
14+
function testFastOs() {
15+
assert.strictEqual(typeof totalmem(), 'number');
16+
assert.strictEqual(typeof freemem(), 'number');
17+
assert.strictEqual(typeof availableParallelism(), 'number');
18+
}
19+
20+
eval('%PrepareFunctionForOptimization(testFastOs)');
21+
testFastOs();
22+
eval('%OptimizeFunctionOnNextCall(testFastOs)');
23+
testFastOs();
24+
25+
if (common.isDebug) {
26+
const { getV8FastApiCallCount } = internalBinding('debug');
27+
assert.strictEqual(getV8FastApiCallCount('os.totalmem'), 1);
28+
assert.strictEqual(getV8FastApiCallCount('os.freemem'), 1);
29+
assert.strictEqual(getV8FastApiCallCount('os.availableParallelism'), 1);
30+
}

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL