build: remove redundant -fuse-linker-plugin from GCC LTO flags · nodejs/node@3bc2bac · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 750
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 3bc2bac

Browse filesBrowse the repository at this point in the historyBrowse files

robertsLando

authored and

juanarbol

committed

build: remove redundant -fuse-linker-plugin from GCC LTO flags

The `-fuse-linker-plugin` flag has been automatically enabled by GCC since version 5 when LTO is active, making the explicit flag redundant. Since Node.js requires GCC >= 13.2, this flag serves no purpose. Removing it also improves portability with alternative linkers (mold, lld) that may not support GCC's linker plugin interface, avoiding build failures when these linkers are used with GCC LTO builds. Refs: yao-pkg/pkg#231 Signed-off-by: Daniel Lando <daniel.sorridi@gmail.com> PR-URL: #62667 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

1 parent 2e5ea5d commit 3bc2bac
Copy full SHA for 3bc2bac

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• common.gypi

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -192,7 +192,7 @@
192	192	['clang==1', {
193	193	'lto': ' -flto ', # Clang
194	194	}, {
195		- 'lto': ' -flto=4 -fuse-linker-plugin -ffat-lto-objects ', # GCC
	195	+ 'lto': ' -flto=4 -ffat-lto-objects ', # GCC
196	196	}],
197	197	],
198	198	},

0 commit comments

Comments

0 (0)