test: spin longer on flaky platforms for test-worker-prof · nodejs/node@3bf42a5 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 748
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 3bf42a5

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

aduh95

committed

test: spin longer on flaky platforms for test-worker-prof

Try spinning longer to get more ticks on flaky platforms and reduce flakiness. PR-URL: #60492 Refs: https://github.com/nodejs/reliability/blob/main/reports/2025-10-29.md Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 3446cf3 commit 3bf42a5
Copy full SHA for 3bf42a5

1 file changed

+7-1Lines changed: 7 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/sequential
  • test-worker-prof.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/sequential/test-worker-prof.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-worker-prof.js

+7-1Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -16,10 +16,16 @@ if (process.argv[2] === 'child') {
16	16	console.log('parent prof file:', parentProf);
17	17
18	18	const { Worker } = require('worker_threads');
	19	+ let spinTime = 1500;
	20	+ if (common.isWindows || common.isMacOS || process.arch === 's390x') {
	21	+ // Windows and MacOS tend to be flaky in CI, s390x as well.
	22	+ // Give them more spins.
	23	+ spinTime = 4500;
	24	+ }
19	25	const w = new Worker(`
20	26	const { parentPort, workerData } = require('worker_threads');
21	27
22		- const SPIN_MS = 1500;
	28	+ const SPIN_MS = ${spinTime};
23	29	const start = Date.now();
24	30	parentPort.on('message', (data) => {
25	31	if (Date.now() - start < SPIN_MS) {

0 commit comments

Comments

0 (0)