src: use BaseObject::kInternalFieldCount in X509Certificate constructor · nodejs/node@3c12941 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 590
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 3c12941

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

ruyadorno

committed

src: use BaseObject::kInternalFieldCount in X509Certificate constructor

Use defined constant instead of hard-coding the field count PR-URL: #36892 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 82c05f5 commit 3c12941
Copy full SHA for 3c12941

1 file changed

+2-1Lines changed: 2 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src/crypto
  • crypto_x509.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/crypto/crypto_x509.cc‎

Copy file name to clipboardExpand all lines: src/crypto/crypto_x509.cc

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -56,7 +56,8 @@ Local<FunctionTemplate> X509Certificate::GetConstructorTemplate(
56	56	Local<FunctionTemplate> tmpl = env->x509_constructor_template();
57	57	if (tmpl.IsEmpty()) {
58	58	tmpl = FunctionTemplate::New(env->isolate());
59		- tmpl->InstanceTemplate()->SetInternalFieldCount(1);
	59	+ tmpl->InstanceTemplate()->SetInternalFieldCount(
	60	+ BaseObject::kInternalFieldCount);
60	61	tmpl->Inherit(BaseObject::GetConstructorTemplate(env));
61	62	tmpl->SetClassName(
62	63	FIXED_ONE_BYTE_STRING(env->isolate(), "X509Certificate"));

0 commit comments

Comments

0 (0)