Commit 3c4541f
lib: simplify IPv6 checks in isLoopback()
The checks for '[::1]' and '[0:0:0:0:0:0:0:1]'
in isLoopback were using startsWith,
which is unnecessary as these are canonical
loopback addresses with no valid prefixes.
Switching to strict equality improves
clarity and improves performance.
PR-URL: #59375
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>1 parent 77682b5 commit 3c4541f
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -79,8 +79,8 @@ function isLoopback(host) { | |||
| 79 | 79 | return ( | |
| 80 | 80 | hostLower === 'localhost' || | |
| 81 | 81 | hostLower.startsWith('127.') || | |
| 82 | - hostLower.startsWith('[::1]') || | ||
| 83 | - hostLower.startsWith('[0:0:0:0:0:0:0:1]') | ||
| 82 | + hostLower === '[::1]' || | ||
| 83 | + hostLower === '[0:0:0:0:0:0:0:1]' | ||
| 84 | 84 | ); | |
| 85 | 85 | } | |
| 86 | 86 | ||
0 commit comments