Commit 3c8782f
committed
deps: silence V8's warning on CompileFunction
We are not ready to migrate yet.
Refs: nodejs/node-v8#214
PR-URL: #40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 80c5a65 commit 3c8782f
2 files changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.8', | ||
| 39 | + 'v8_embedder_string': '-node.9', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -692,7 +692,6 @@ class V8_EXPORT ScriptCompiler { | |||
| 692 | 692 | * It is possible to specify multiple context extensions (obj in the above | |
| 693 | 693 | * example). | |
| 694 | 694 | */ | |
| 695 | - V8_DEPRECATE_SOON("Use CompileFunction") | ||
| 696 | 695 | static V8_WARN_UNUSED_RESULT MaybeLocal<Function> CompileFunctionInContext( | |
| 697 | 696 | Local<Context> context, Source* source, size_t arguments_count, | |
| 698 | 697 | Local<String> arguments[], size_t context_extension_count, | |
0 commit comments