http: refactor to use min of validateNumber for maxTotalSockets · nodejs/node@3d1dd96 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 759
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 3d1dd96

Browse filesBrowse the repository at this point in the historyBrowse files

deokjinkim

authored and

juanarbol

committed

http: refactor to use min of validateNumber for maxTotalSockets

Remove duplicate implementation by using min of validateNumber. PR-URL: #46115 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 53ecd20 commit 3d1dd96
Copy full SHA for 3d1dd96

2 files changed

+1-12Lines changed: 1 addition & 12 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • _http_agent.js
• test/parallel
  • test-http-agent-maxtotalsockets.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/_http_agent.js‎

Copy file name to clipboardExpand all lines: lib/_http_agent.js

+1-10Lines changed: 1 addition & 10 deletions

Original file line number	Diff line number	Diff line change
@@ -30,7 +30,6 @@ const {
30	30	ArrayPrototypeSome,
31	31	ArrayPrototypeSplice,
32	32	FunctionPrototypeCall,
33		- NumberIsNaN,
34	33	ObjectCreate,
35	34	ObjectKeys,
36	35	ObjectSetPrototypeOf,
@@ -49,11 +48,6 @@ let debug = require('internal/util/debuglog').debuglog('http', (fn) => {
49	48	});
50	49	const { AsyncResource } = require('async_hooks');
51	50	const { async_id_symbol } = require('internal/async_hooks').symbols;
52		- const {
53		- codes: {
54		- ERR_OUT_OF_RANGE,
55		- },
56		- } = require('internal/errors');
57	51	const {
58	52	kEmptyObject,
59	53	once,
@@ -123,10 +117,7 @@ function Agent(options) {
123	117	validateOneOf(this.scheduling, 'scheduling', ['fifo', 'lifo']);
124	118
125	119	if (this.maxTotalSockets !== undefined) {
126		- validateNumber(this.maxTotalSockets, 'maxTotalSockets');
127		- if (this.maxTotalSockets <= 0 || NumberIsNaN(this.maxTotalSockets))
128		- throw new ERR_OUT_OF_RANGE('maxTotalSockets', '> 0',
129		- this.maxTotalSockets);
	120	+ validateNumber(this.maxTotalSockets, 'maxTotalSockets', 1);
130	121	} else {
131	122	this.maxTotalSockets = Infinity;
132	123	}

Collapse file

‎test/parallel/test-http-agent-maxtotalsockets.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-agent-maxtotalsockets.js

-2Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -20,8 +20,6 @@ assert.throws(() => new http.Agent({
20	20	}), {
21	21	code: 'ERR_OUT_OF_RANGE',
22	22	name: 'RangeError',
23		- message: 'The value of "maxTotalSockets" is out of range. ' +
24		- `It must be > 0. Received ${item}`,
25	23	});
26	24	});
27	25

0 commit comments

Comments

0 (0)