Commit 3d438f8
test: configure certs in tests
OpenSSL 1.1.0 disables anonymous ciphers unless building with
enable-weak-crypto. Avoid unnecessary dependencies on these ciphers in
tests.
PR-URL: #16130
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rod Vagg <rod@vagg.org>1 parent 07102ac commit 3d438f8
2 files changed
Lines changed: 10 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -7,20 +7,22 @@ if (!common.hasIPv6) | |||
| 7 | 7 | common.skip('no IPv6 support'); | |
| 8 | 8 | ||
| 9 | 9 | const assert = require('assert'); | |
| 10 | + const fixtures = require('../common/fixtures'); | ||
| 10 | 11 | const https = require('https'); | |
| 11 | 12 | const dns = require('dns'); | |
| 12 | 13 | ||
| 13 | 14 | function runTest() { | |
| 14 | - const ciphers = 'AECDH-NULL-SHA'; | ||
| 15 | - https.createServer({ ciphers }, common.mustCall(function(req, res) { | ||
| 15 | + https.createServer({ | ||
| 16 | + cert: fixtures.readKey('agent1-cert.pem'), | ||
| 17 | + key: fixtures.readKey('agent1-key.pem'), | ||
| 18 | + }, common.mustCall(function(req, res) { | ||
| 16 | 19 | this.close(); | |
| 17 | 20 | res.end(); | |
| 18 | 21 | })).listen(0, '::1', common.mustCall(function() { | |
| 19 | 22 | const options = { | |
| 20 | 23 | host: 'localhost', | |
| 21 | 24 | port: this.address().port, | |
| 22 | 25 | family: 6, | |
| 23 | - ciphers: ciphers, | ||
| 24 | 26 | rejectUnauthorized: false, | |
| 25 | 27 | }; | |
| 26 | 28 | // Will fail with ECONNREFUSED if the address family is not honored. | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -7,19 +7,21 @@ if (!common.hasIPv6) | |||
| 7 | 7 | common.skip('no IPv6 support'); | |
| 8 | 8 | ||
| 9 | 9 | const assert = require('assert'); | |
| 10 | + const fixtures = require('../common/fixtures'); | ||
| 10 | 11 | const tls = require('tls'); | |
| 11 | 12 | const dns = require('dns'); | |
| 12 | 13 | ||
| 13 | 14 | function runTest() { | |
| 14 | - const ciphers = 'AECDH-NULL-SHA'; | ||
| 15 | - tls.createServer({ ciphers }, common.mustCall(function() { | ||
| 15 | + tls.createServer({ | ||
| 16 | + cert: fixtures.readKey('agent1-cert.pem'), | ||
| 17 | + key: fixtures.readKey('agent1-key.pem'), | ||
| 18 | + }, common.mustCall(function() { | ||
| 16 | 19 | this.close(); | |
| 17 | 20 | })).listen(0, '::1', common.mustCall(function() { | |
| 18 | 21 | const options = { | |
| 19 | 22 | host: 'localhost', | |
| 20 | 23 | port: this.address().port, | |
| 21 | 24 | family: 6, | |
| 22 | - ciphers: ciphers, | ||
| 23 | 25 | rejectUnauthorized: false, | |
| 24 | 26 | }; | |
| 25 | 27 | // Will fail with ECONNREFUSED if the address family is not honored. | |
0 commit comments