Commit 3db37e7
inspector: refactor inspector/promises to be more robust
Limit the effect of users mutating `node:util`, `node:inspector`, or
`Array.prototype`.
PR-URL: #45041
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 2e5d8e7 commit 3db37e7
1 file changed
Lines changed: 4 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,20 +1,12 @@ | |||
| 1 | 1 | 'use strict'; | |
| 2 | 2 | ||
| 3 | 3 | const inspector = require('inspector'); | |
| 4 | - const { promisify } = require('util'); | ||
| 5 | - const { FunctionPrototypeBind } = primordials; | ||
| 4 | + const { promisify } = require('internal/util'); | ||
| 5 | + | ||
| 6 | 6 | class Session extends inspector.Session { | |
| 7 | - #post = promisify(FunctionPrototypeBind(super.post, this)); | ||
| 8 | - /** | ||
| 9 | - * Posts a message to the inspector back-end. | ||
| 10 | - * @param {string} method | ||
| 11 | - * @param {Record<unknown, unknown>} [params] | ||
| 12 | - * @returns {Promise} | ||
| 13 | - */ | ||
| 14 | - async post(method, params) { | ||
| 15 | - return this.#post(method, params); | ||
| 16 | - } | ||
| 7 | + constructor() { super(); } // eslint-disable-line no-useless-constructor | ||
| 17 | 8 | } | |
| 9 | + Session.prototype.post = promisify(inspector.Session.prototype.post); | ||
| 18 | 10 | ||
| 19 | 11 | module.exports = { | |
| 20 | 12 | ...inspector, | |
0 commit comments