Commit 3dc3a31
util: improve empty typed array inspection
They should be aligned with all other empty objects. Therefore the
whitespace is removed and they got a fast path for that.
PR-URL: #22284
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>1 parent acfb724 commit 3dc3a31
2 files changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -625,6 +625,8 @@ function formatValue(ctx, value, recurseTimes) { | |||
| 625 | 625 | formatter = formatMap; | |
| 626 | 626 | } else if (isTypedArray(value)) { | |
| 627 | 627 | braces = [`${getPrefix(constructor, tag)}[`, ']']; | |
| 628 | + if (value.length === 0 && keyLength === 0 && !ctx.showHidden) | ||
| 629 | + return `${braces[0]}]`; | ||
| 628 | 630 | formatter = formatTypedArray; | |
| 629 | 631 | } else if (isMapIterator(value)) { | |
| 630 | 632 | braces = [`[${tag}] {`, '}']; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -79,7 +79,8 @@ assert.strictEqual(util.inspect({ 'a': { 'b': { 'c': 2 } } }, false, 1), | |||
| 79 | 79 | '{ a: { b: [Object] } }'); | |
| 80 | 80 | assert.strictEqual(util.inspect({ 'a': { 'b': ['c'] } }, false, 1), | |
| 81 | 81 | '{ a: { b: [Array] } }'); | |
| 82 | - assert.strictEqual(util.inspect(new Uint8Array(0)), 'Uint8Array [ ]'); | ||
| 82 | + assert.strictEqual(util.inspect(new Uint8Array(0)), 'Uint8Array []'); | ||
| 83 | + assert(inspect(new Uint8Array(0), { showHidden: true }).includes('[buffer]')); | ||
| 83 | 84 | assert.strictEqual( | |
| 84 | 85 | util.inspect( | |
| 85 | 86 | Object.create( | |
0 commit comments