Commit 3df472c
build: build with v8 gdbjit support on supported platform
Build it with gdbjit support on supported platforms by default
allows debugging JIT-compiled code in gdb when it's also enabled
at run time (via --gdbjit). Simply building it in should not
incur an overhead if it's not also enabled at run time.
PR-URL: #61010
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>1 parent 81f1f74 commit 3df472c
1 file changed
Lines changed: 10 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1722,7 +1722,16 @@ def configure_v8(o, configs): | |||
| 1722 | 1722 | o['variables']['v8_enable_webassembly'] = 0 if options.v8_lite_mode else 1 | |
| 1723 | 1723 | o['variables']['v8_enable_javascript_promise_hooks'] = 1 | |
| 1724 | 1724 | o['variables']['v8_enable_lite_mode'] = 1 if options.v8_lite_mode else 0 | |
| 1725 | - o['variables']['v8_enable_gdbjit'] = 1 if options.gdb else 0 | ||
| 1725 | + is_gdbjit_supported_arch = ( | ||
| 1726 | + 'x64' in o['variables']['target_arch'] or | ||
| 1727 | + 'ia32' in o['variables']['target_arch'] or | ||
| 1728 | + 'ppc64' in o['variables']['target_arch'] | ||
| 1729 | + ) | ||
| 1730 | + is_linux = flavor == 'linux' | ||
| 1731 | + if (options.gdb is not None): | ||
| 1732 | + o['variables']['v8_enable_gdbjit'] = 1 if options.gdb else 0 | ||
| 1733 | + else: | ||
| 1734 | + o['variables']['v8_enable_gdbjit'] = 1 if is_gdbjit_supported_arch and is_linux else 0 | ||
| 1726 | 1735 | o['variables']['v8_optimized_debug'] = 0 if options.v8_non_optimized_debug else 1 | |
| 1727 | 1736 | o['variables']['dcheck_always_on'] = 1 if options.v8_with_dchecks else 0 | |
| 1728 | 1737 | o['variables']['v8_enable_object_print'] = 0 if options.v8_disable_object_print else 1 | |
0 commit comments