Commit 3e68e44
committed
src: remove empty comment in node_http2.h
This commit removes an "empty" comment in node_http2.h that I don't
think was intentional and as far as I can tell not a doxygen comment or
anything like that.
This was not picked up by the cpp linter so a suggestion has also been
added to the CheckComment function to detect these in the future.
PR-URL: #16400
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 50d7275 commit 3e68e44
2 files changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -333,7 +333,6 @@ class Http2Options { | |||
| 333 | 333 | ||
| 334 | 334 | static const size_t kAllocBufferSize = 64 * 1024; | |
| 335 | 335 | ||
| 336 | - //// | ||
| 337 | 336 | typedef uint32_t(*get_setting)(nghttp2_session* session, | |
| 338 | 337 | nghttp2_settings_id id); | |
| 339 | 338 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3021,7 +3021,7 @@ def CheckComment(line, filename, linenum, next_line_start, error): | |||
| 3021 | 3021 | # If the comment contains an alphanumeric character, there | |
| 3022 | 3022 | # should be a space somewhere between it and the // unless | |
| 3023 | 3023 | # it's a /// or //! Doxygen comment. | |
| 3024 | - if (Match(r'//[^ ]*\w', comment) and | ||
| 3024 | + if (Match(r'(?://[^ ]*\w)|(?:////\s*$)', comment) and | ||
| 3025 | 3025 | not Match(r'(///|//\!)(\s+|$)', comment)): | |
| 3026 | 3026 | error(filename, linenum, 'whitespace/comments', 4, | |
| 3027 | 3027 | 'Should have a space between // and comment') | |
0 commit comments