Commit 3e6d992
tools: remove NODE_PATH from environment for tests
Unset NODE_PATH environment variable when running tests.
On Ubuntu 16.04, some users experience test failures due to internal
libraries being installed in /usr/lib/nodejs/internal and NODE_PATH
including /usr/lib/nodejs. Tests that expect internal libraries to be
off limits without the --expose-internals flag will fail in this
situation. Currently, those tests are test/parallel/test-repl.js and
test/parallel/test-internal-modules.js.
This situation seems to (probably) be caused by some
not-entirely-uncommon package that gets installed.
Regardless, tests should ignore the user's NODE_PATH. (NODE_PATH is
tested in test/parallel/test-module-globalpaths-nodepath.js and
test/parallel/test-require-dot.js.)
PR-URL: #11612
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Refs: https://twitter.com/trott/status/8357293969000611841 parent 5d74c9e commit 3e6d992
1 file changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -702,8 +702,13 @@ def Execute(args, context, timeout=None, env={}, faketty=False): | |||
| 702 | 702 | fd_in = 0 | |
| 703 | 703 | pty_out = None | |
| 704 | 704 | ||
| 705 | - # Extend environment | ||
| 706 | 705 | env_copy = os.environ.copy() | |
| 706 | + | ||
| 707 | + # Remove NODE_PATH | ||
| 708 | + if "NODE_PATH" in env_copy: | ||
| 709 | + del env_copy["NODE_PATH"] | ||
| 710 | + | ||
| 711 | + # Extend environment | ||
| 707 | 712 | for key, value in env.iteritems(): | |
| 708 | 713 | env_copy[key] = value | |
| 709 | 714 | ||
0 commit comments