http: writeHead if statusmessage is undefined dont override headers · nodejs/node@3e70b7d · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 634
• Pull requests 592
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 3e70b7d

Browse filesBrowse the repository at this point in the historyBrowse files

marco-ippolito

authored and

juanarbol

committed

http: writeHead if statusmessage is undefined dont override headers

PR-URL: #46173 Fixes: #32395 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

1 parent 7c03a3d commit 3e70b7d
Copy full SHA for 3e70b7d

2 files changed

+19-1Lines changed: 19 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • _http_server.js
• test/parallel
  • test-http-write-head-2.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/_http_server.js‎

Copy file name to clipboardExpand all lines: lib/_http_server.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -352,7 +352,7 @@ function writeHead(statusCode, reason, obj) {
352	352	// writeHead(statusCode[, headers])
353	353	if (!this.statusMessage)
354	354	this.statusMessage = STATUS_CODES[statusCode] || 'unknown';
355		- obj = reason;
	355	+ obj ??= reason;
356	356	}
357	357	this.statusCode = statusCode;
358	358

Collapse file

‎test/parallel/test-http-write-head-2.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-write-head-2.js

+18Lines changed: 18 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -59,3 +59,21 @@ const http = require('http');
59	59	}));
60	60	}));
61	61	}
	62	+
	63	+ {
	64	+ const server = http.createServer(common.mustCall((req, res) => {
	65	+ res.writeHead(200, undefined, [ 'foo', 'bar' ]);
	66	+ res.end();
	67	+ }));
	68	+
	69	+ server.listen(0, common.mustCall(() => {
	70	+ http.get({ port: server.address().port }, common.mustCall((res) => {
	71	+ assert.strictEqual(res.statusMessage, 'OK');
	72	+ assert.strictEqual(res.statusCode, 200);
	73	+ assert.strictEqual(res.headers.foo, 'bar');
	74	+ res.resume().on('end', common.mustCall(() => {
	75	+ server.close();
	76	+ }));
	77	+ }));
	78	+ }));
	79	+ }

0 commit comments

Comments

0 (0)