Commit 3f12109
test: refactor test-internal-errors
Use block-scoping rather than `err1`, `err2`, etc.
PR-URL: #15721
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent df1d988 commit 3f12109
1 file changed
Lines changed: 39 additions & 30 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -12,36 +12,45 @@ function invalidKey(key) { | |||
| 12 | 12 | errors.E('TEST_ERROR_1', 'Error for testing purposes: %s'); | |
| 13 | 13 | errors.E('TEST_ERROR_2', (a, b) => `${a} ${b}`); | |
| 14 | 14 | ||
| 15 | - const err1 = new errors.Error('TEST_ERROR_1', 'test'); | ||
| 16 | - const err2 = new errors.TypeError('TEST_ERROR_1', 'test'); | ||
| 17 | - const err3 = new errors.RangeError('TEST_ERROR_1', 'test'); | ||
| 18 | - const err4 = new errors.Error('TEST_ERROR_2', 'abc', 'xyz'); | ||
| 19 | - const err5 = new errors.Error('TEST_ERROR_1'); | ||
| 20 | - | ||
| 21 | - assert(err1 instanceof Error); | ||
| 22 | - assert.strictEqual(err1.name, 'Error [TEST_ERROR_1]'); | ||
| 23 | - assert.strictEqual(err1.message, 'Error for testing purposes: test'); | ||
| 24 | - assert.strictEqual(err1.code, 'TEST_ERROR_1'); | ||
| 25 | - | ||
| 26 | - assert(err2 instanceof TypeError); | ||
| 27 | - assert.strictEqual(err2.name, 'TypeError [TEST_ERROR_1]'); | ||
| 28 | - assert.strictEqual(err2.message, 'Error for testing purposes: test'); | ||
| 29 | - assert.strictEqual(err2.code, 'TEST_ERROR_1'); | ||
| 30 | - | ||
| 31 | - assert(err3 instanceof RangeError); | ||
| 32 | - assert.strictEqual(err3.name, 'RangeError [TEST_ERROR_1]'); | ||
| 33 | - assert.strictEqual(err3.message, 'Error for testing purposes: test'); | ||
| 34 | - assert.strictEqual(err3.code, 'TEST_ERROR_1'); | ||
| 35 | - | ||
| 36 | - assert(err4 instanceof Error); | ||
| 37 | - assert.strictEqual(err4.name, 'Error [TEST_ERROR_2]'); | ||
| 38 | - assert.strictEqual(err4.message, 'abc xyz'); | ||
| 39 | - assert.strictEqual(err4.code, 'TEST_ERROR_2'); | ||
| 40 | - | ||
| 41 | - assert(err5 instanceof Error); | ||
| 42 | - assert.strictEqual(err5.name, 'Error [TEST_ERROR_1]'); | ||
| 43 | - assert.strictEqual(err5.message, 'Error for testing purposes: %s'); | ||
| 44 | - assert.strictEqual(err5.code, 'TEST_ERROR_1'); | ||
| 15 | + { | ||
| 16 | + const err = new errors.Error('TEST_ERROR_1', 'test'); | ||
| 17 | + assert(err instanceof Error); | ||
| 18 | + assert.strictEqual(err.name, 'Error [TEST_ERROR_1]'); | ||
| 19 | + assert.strictEqual(err.message, 'Error for testing purposes: test'); | ||
| 20 | + assert.strictEqual(err.code, 'TEST_ERROR_1'); | ||
| 21 | + } | ||
| 22 | + | ||
| 23 | + { | ||
| 24 | + const err = new errors.TypeError('TEST_ERROR_1', 'test'); | ||
| 25 | + assert(err instanceof TypeError); | ||
| 26 | + assert.strictEqual(err.name, 'TypeError [TEST_ERROR_1]'); | ||
| 27 | + assert.strictEqual(err.message, 'Error for testing purposes: test'); | ||
| 28 | + assert.strictEqual(err.code, 'TEST_ERROR_1'); | ||
| 29 | + } | ||
| 30 | + | ||
| 31 | + { | ||
| 32 | + const err = new errors.RangeError('TEST_ERROR_1', 'test'); | ||
| 33 | + assert(err instanceof RangeError); | ||
| 34 | + assert.strictEqual(err.name, 'RangeError [TEST_ERROR_1]'); | ||
| 35 | + assert.strictEqual(err.message, 'Error for testing purposes: test'); | ||
| 36 | + assert.strictEqual(err.code, 'TEST_ERROR_1'); | ||
| 37 | + } | ||
| 38 | + | ||
| 39 | + { | ||
| 40 | + const err = new errors.Error('TEST_ERROR_2', 'abc', 'xyz'); | ||
| 41 | + assert(err instanceof Error); | ||
| 42 | + assert.strictEqual(err.name, 'Error [TEST_ERROR_2]'); | ||
| 43 | + assert.strictEqual(err.message, 'abc xyz'); | ||
| 44 | + assert.strictEqual(err.code, 'TEST_ERROR_2'); | ||
| 45 | + } | ||
| 46 | + | ||
| 47 | + { | ||
| 48 | + const err = new errors.Error('TEST_ERROR_1'); | ||
| 49 | + assert(err instanceof Error); | ||
| 50 | + assert.strictEqual(err.name, 'Error [TEST_ERROR_1]'); | ||
| 51 | + assert.strictEqual(err.message, 'Error for testing purposes: %s'); | ||
| 52 | + assert.strictEqual(err.code, 'TEST_ERROR_1'); | ||
| 53 | + } | ||
| 45 | 54 | ||
| 46 | 55 | assert.throws( | |
| 47 | 56 | () => new errors.Error('TEST_FOO_KEY'), | |
0 commit comments