Commit 3f6f968
test: skip tests related to CI failures on AIX
These tests seem to trigger failures in the entire CI job (not just the
test) on AIX. Skip them to see if that helps alleviate spurious failures
in node-test-commit-aix (and the upstream PR and commit test jobs).
See:
- nodejs/build#1820 (comment)
- nodejs/build#1847 (comment)
PR-URL: #28469
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 1b4a7fb commit 3f6f968
4 files changed
Lines changed: 15 additions & 0 deletions
File tree
- test
- addons/stringbytes-external-exceed-max
- message
- pseudo-tty
- sequential
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5,6 +5,11 @@ const skipMessage = 'intensive toString tests due to memory confinements'; | |||
| 5 | 5 | if (!common.enoughTestMem) | |
| 6 | 6 | common.skip(skipMessage); | |
| 7 | 7 | ||
| 8 | + // See https://github.com/nodejs/build/issues/1820#issuecomment-505998851 | ||
| 9 | + // See https://github.com/nodejs/node/pull/28469 | ||
| 10 | + if (process.platform === 'aix') | ||
| 11 | + common.skip('flaky on AIX'); | ||
| 12 | + | ||
| 8 | 13 | const binding = require(`./build/${common.buildType}/binding`); | |
| 9 | 14 | ||
| 10 | 15 | // v8 fails silently if string length > v8::String::kMaxLength | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -16,3 +16,6 @@ prefix message | |||
| 16 | 16 | ||
| 17 | 17 | [$system==freebsd] | |
| 18 | 18 | ||
| 19 | + [$system==aix] | ||
| 20 | + # https://github.com/nodejs/node/pull/28469 | ||
| 21 | + vm_dont_display_syntax_error: SKIP | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,6 +1,10 @@ | |||
| 1 | 1 | prefix pseudo-tty | |
| 2 | 2 | ||
| 3 | 3 | [$system==aix] | |
| 4 | + # https://github.com/nodejs/build/issues/1820#issuecomment-505998851 | ||
| 5 | + # https://github.com/nodejs/node/pull/28469 | ||
| 6 | + console-dumb-tty: SKIP | ||
| 7 | + test-fatal-error: SKIP | ||
| 4 | 8 | ||
| 5 | 9 | [$system==solaris] | |
| 6 | 10 | # https://github.com/nodejs/node/pull/16225 - `ioctl(fd, TIOCGWINSZ)` seems | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -19,5 +19,8 @@ test-http2-large-file: PASS, FLAKY | |||
| 19 | 19 | [$system==freebsd] | |
| 20 | 20 | ||
| 21 | 21 | [$system==aix] | |
| 22 | + # https://github.com/nodejs/node/pull/28469 | ||
| 23 | + test-async-wrap-getasyncid: SKIP | ||
| 24 | + test-buffer-creation-regression: SKIP | ||
| 22 | 25 | ||
| 23 | 26 | [$arch==arm] | |
0 commit comments