test: adjust CLI flags test to ignore blank lines in doc · nodejs/node@3f7c503 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 757
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 3f7c503

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

targos

committed

test: adjust CLI flags test to ignore blank lines in doc

PR-URL: #40403 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

1 parent adbd92e commit 3f7c503
Copy full SHA for 3f7c503

1 file changed

+4-1Lines changed: 4 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-process-env-allowed-flags-are-documented.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-process-env-allowed-flags-are-documented.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-process-env-allowed-flags-are-documented.js

+4-1Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -15,7 +15,9 @@ const parseSection = (text, startMarker, endMarker) => {
15	15	const match = text.match(regExp);
16	16	assert(match,
17	17	`Unable to locate text between '${startMarker}' and '${endMarker}'.`);
18		- return match[1].split(/\r?\n/);
	18	+ return match[1]
	19	+ .split(/\r?\n/)
	20	+ .filter((val) => val.trim() !== '');
19	21	};
20	22
21	23	const nodeOptionsLines = parseSection(cliText,
@@ -24,6 +26,7 @@ const nodeOptionsLines = parseSection(cliText,
24	26	const v8OptionsLines = parseSection(cliText,
25	27	'<!-- node-options-v8 start -->',
26	28	'<!-- node-options-v8 end -->');
	29	+
27	30	// Check the options are documented in alphabetical order.
28	31	assert.deepStrictEqual(nodeOptionsLines, [...nodeOptionsLines].sort());
29	32	assert.deepStrictEqual(v8OptionsLines, [...v8OptionsLines].sort());

0 commit comments

Comments

0 (0)