Commit 3f7d55b
test: add AbortController to knownGlobals
PR-URL: #53020
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>1 parent 5110b19 commit 3f7d55b
1 file changed
Lines changed: 1 addition & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -280,6 +280,7 @@ function platformTimeout(ms) { | |||
| 280 | 280 | } | |
| 281 | 281 | ||
| 282 | 282 | let knownGlobals = [ | |
| 283 | + AbortController, | ||
| 283 | 284 | atob, | |
| 284 | 285 | btoa, | |
| 285 | 286 | clearImmediate, | |
@@ -292,15 +293,6 @@ let knownGlobals = [ | |||
| 292 | 293 | queueMicrotask, | |
| 293 | 294 | ]; | |
| 294 | 295 | ||
| 295 | - // TODO(@jasnell): This check can be temporary. AbortController is | ||
| 296 | - // not currently supported in either Node.js 12 or 10, making it | ||
| 297 | - // difficult to run tests comparatively on those versions. Once | ||
| 298 | - // all supported versions have AbortController as a global, this | ||
| 299 | - // check can be removed and AbortController can be added to the | ||
| 300 | - // knownGlobals list above. | ||
| 301 | - if (global.AbortController) | ||
| 302 | - knownGlobals.push(global.AbortController); | ||
| 303 | - | ||
| 304 | 296 | if (global.gc) { | |
| 305 | 297 | knownGlobals.push(global.gc); | |
| 306 | 298 | } | |
0 commit comments