cluster: removed unused addressType argument from constructor · nodejs/node@4035cbe · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 636
• Pull requests 762
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 4035cbe

Browse filesBrowse the repository at this point in the historyBrowse files

yashLadha

authored and

BethGriggs

committed

cluster: removed unused addressType argument from constructor

When intializing the constructor for cluster master we are heavily using a generic structure, but the effect of passing arguments that are related to shared_handle is that there is a stale argument passed. We can avoid such scenarios as all the remaining entities are being destructured from the message object. PR-URL: #32963 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

1 parent 23eda41 commit 4035cbe
Copy full SHA for 4035cbe

3 files changed

+3-8Lines changed: 3 additions & 8 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/cluster
  • master.js
  • round_robin_handle.js
  • shared_handle.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/cluster/master.js‎

Copy file name to clipboardExpand all lines: lib/internal/cluster/master.js

+1-6Lines changed: 1 addition & 6 deletions

Original file line number	Diff line number	Diff line change
@@ -297,12 +297,7 @@ function queryServer(worker, message) {
297	297	constructor = SharedHandle;
298	298	}
299	299
300		- handle = new constructor(key,
301		- address,
302		- message.port,
303		- message.addressType,
304		- message.fd,
305		- message.flags);
	300	+ handle = new constructor(key, address, message);
306	301	handles.set(key, handle);
307	302	}
308	303

Collapse file

‎lib/internal/cluster/round_robin_handle.js‎

Copy file name to clipboardExpand all lines: lib/internal/cluster/round_robin_handle.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -13,7 +13,7 @@ const { constants } = internalBinding('tcp_wrap');
13	13
14	14	module.exports = RoundRobinHandle;
15	15
16		- function RoundRobinHandle(key, address, port, addressType, fd, flags) {
	16	+ function RoundRobinHandle(key, address, { port, fd, flags }) {
17	17	this.key = key;
18	18	this.all = new Map();
19	19	this.free = new Map();

Collapse file

‎lib/internal/cluster/shared_handle.js‎

Copy file name to clipboardExpand all lines: lib/internal/cluster/shared_handle.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -6,7 +6,7 @@ const net = require('net');
6	6
7	7	module.exports = SharedHandle;
8	8
9		- function SharedHandle(key, address, port, addressType, fd, flags) {
	9	+ function SharedHandle(key, address, { port, addressType, fd, flags }) {
10	10	this.key = key;
11	11	this.workers = new Map();
12	12	this.handle = null;

0 commit comments

Comments

0 (0)